CyberShadow / DFeed

D news aggregator, newsgroup client, web newsreader and IRC bot
http://forum.dlang.org/help#about
381 stars 35 forks source link

Remembering how many captchas passed, limiting the number asked for #68

Closed cyisfor closed 8 years ago

cyisfor commented 8 years ago

This is sort of what I was thinking. Some users (like myself) get an endless stream of demands from Akismet no matter what we do, and it really would make the site more performant if it didn't query that place for every post, even those of well established users. So, this commit checks how many captchas a user has filled out, and if that number is high enough, does not check their account for spam anymore. The number could be set arbitrarily high, however much before spammers give up trying, but eventually users should silently start seeing their posts just succeed, even if they would have been a false positive on Akismet.

This compiles, but I have no real way to test whether it actually works or not. With or without my commit, running dfeed just gives me the reply "Internal Server Error" for every URL with no diagnostic information anywhere.

Anyway, I just wanted to put out there what sort of change I wanted to see in the forum.

CyberShadow commented 8 years ago

Thanks for the PR. I'd like to implement it a little differently so I'll have a go at it myself.

This compiles, but I have no real way to test whether it actually works or not. With or without my commit, running dfeed just gives me the reply "Internal Server Error" for every URL with no diagnostic information anywhere.

If you build with -debug, it will show a stack trace, and with -debug=NO_CATCH, exceptions will be propagated to the top level.

CyberShadow commented 8 years ago

https://github.com/CyberShadow/DFeed/commit/7bd55ad6c3d0e56db8b80686156f341e40dad2cb

CyberShadow commented 8 years ago

@cyisfor From the silence / lack of complaints I'm guessing you're happy with my change, closing :)