search

CybercentreCanada / assemblyline

AssemblyLine 4: File triage and malware analysis
https://cybercentrecanada.github.io/assemblyline4_docs/
MIT License
249 stars 15 forks source link

Finding related submissions doesn't work for supplementary files #199

Open kam193 opened 9 months ago

kam193 commented 9 months ago

Describe the bug If trying to find submissions related to a supplementary file, no submission is found. It looks like it's not really a problem in a normal flow (the only use case I find is to look for other submissions with the same supp. file, probably a rare case), but it's more painful in malware archive, which operates on files, not submissions - and thus, it's very useful to understand where a file comes from.

To Reproduce Steps to reproduce the behavior:

  1. Open a submission with some results.
  2. Click on results details, and open the preview of any supplementary file (e.g. even ontology).
  3. Click on "Related submissions" button.
  4. Observe no submission found

OR

  1. Generate an archived submission with some supplementary files.
  2. Go to the archive, click on any supplementary file (again, even an ontology file).
  3. Click on "Related submissions" button.
  4. Observe no results.

Expected behavior Related submissions are found.

Screenshots

Environment (please complete the following information if pertinent):

cccs-rs commented 7 months ago

This can be due to the fact that looking for "Related Submissions" will point you to the Submission index and supplementary files aren't included in the files field of a Submission, only files that seem to have been submitted.

Perhaps this could be amended to include supplementary files as well upon submission completion?