CyberdyneCC / Thermos

(NO LONGER DEVELOPED) Minecraft Forge Server Software implementing the Spigot/Bukkit API, formerly known as Cauldron/MCPC
http://cyberdynecc.github.io/Thermos/
GNU General Public License v3.0
256 stars 184 forks source link

Firing an IC2 Mining Laser cannot be tracked in Bukkit #338

Closed StargateMC closed 8 years ago

StargateMC commented 8 years ago

This is a long standing bug that has this item banned on most servers.

The reason this occurs is because the mining laser projectile does not throw a 'ProjectileHitEvent' or ProjectileLaunchEvent in bukkit.

Is there an issue with the mapping of the Forge equivalent?

If there is a way that I am unaware of, please let me know.

My goal here: To stop the item from bypassing faction permissions by calculating the shooters rights to build at the point of impact.

EDIT: This is really weird, IC2 Mining Lasers throw their own events for everything. I'm not sure you can help here?

sameer commented 8 years ago

@DraksterAU I am aware of this, I talked with the developer but he refused to add events that align with Forge (weirdly enough). The only real way to solve the problem would be to either convert the code to match Forge events or make an add-on mod. :confused: Sorry.

spannerman79 commented 8 years ago

Damn it ninja'ed by @Robotia :stuck_out_tongue:

I was about to state that the forge dev for IC2 needs to enforce either a fakeplayer on blockplace/blockbreak or reflect the UUID of the user who owns the TE - in this case the Mining Laser.

And for the record this isn't an issue with Cauldron/kCauldron/Thermos - this happens even while using ForgeEssentials on a vanilla forge server - so go figure. And yes I know as I run a vanilla forge server with ForgeEssentials for kids with learning issues. I removed IC2 as the dev/s shows their unwillingness to not just add in normal forge events but they blame everything and everyone else.

StargateMC commented 8 years ago

@Robotia / @spannerman79 No worries at all.

Forge events or make an add-on mod

If I do that, will Thermos pass the events to bukkit?

IC2 and Massivecraft are just as bad as eachother. Asshats.

PS: Plugin is here: https://www.spigotmc.org/resources/perimeter.22469/

Not sure if anyone wants it .... is designed for us (Thermos users) So :D

StargateMC commented 8 years ago

Working on Quarry & Digiminer support. Plan is to make it so a miner placed in faction can mine that factions land and wilderness only. (Assumes the person who placed it has build rights and knows what theyre doing) A Miner placed in wilderness can mine in wildernesss only.

spannerman79 commented 8 years ago

Digiminer support

If your talking about the Digital Miner from Mekanism there already is a fake player for that. [Mekanism] - I can't remember the UUID but check your logs as it adds a log event stating the UUID https://github.com/aidancbrady/Mekanism/commit/77db81bcf0c0eaaa7f3757e7b1a610b804491253

StargateMC commented 8 years ago

@spannerman79 I know....thanks lol. I'm working on it :P

Having an issue with the fakeplayer reporting the location of the broken block for its location, not the miner/quarry location..... any ideas? @Robotia @spannerman79

Stupid, because in the event the block already knows its location and that can be used.

spannerman79 commented 8 years ago

While using Prism it logs and reports the activity of the fakeplayer and with GPP it correctly blocks or allows the blockbreak/blockplace forge event. I know that's not much help as you want factions support but it will give you a location to start at/peak at code wise.

/personalrant

I've always disliked factions. they use a third party api which serves no real purpose that in my view just makes them lazy. Not to mention their configs....

/endpersonalrant

StargateMC commented 8 years ago

@spannerman79 I admit, they're not the most pleasant people (aka. Assholes?) (they've been offered t he 1 line of code required to support cauldron officially and declined it citing it was bad coding).

But they also use develop plugin that actually has some "sense" of realism to it. Not a golden shovel tool.

spannerman79 commented 8 years ago

You can use whatever item you like in the configs. golden shovel is default. same with the stick or the newbie option of setting a claim by placing down a chest.

StargateMC commented 8 years ago

@spannerman79 Does GP support alliances? War? etc? Not having a go at it, I'm just trying to theme my server to a bit of RP and "Factions" suites (So would nations/empires whatever you call it).... but It would need to involve relations. http://stargatemc.com - my little project haha :)

spannerman79 commented 8 years ago

No - its more towards PvE not PvP.

As for PvP there isn't much choice - Factions is the only real plugin that can offer a war type setting..

You could do PvP with GPP but it will require the use of other plugins and mods and quite a bit of setting up using CustomNPC's to set the player faction type/group. Screwed if you do screwed if you don't LOL

StargateMC commented 8 years ago

@spannerman79 Towny and other similar plugins also do it.

Yep, really are.

I learned some Java and have developed several little plugins/mods to handle the 'fuck you' that I've been given when asking from help... QQ haha

Razorskills commented 8 years ago

@DraksterAU Here is a mod I used to use for the mining laser. But lots has changed with mc since I used it. maybe op would be willing to let you update it. http://forum.industrial-craft.net/index.php?page=Thread&threadID=10527

ghost commented 8 years ago

I've already fixed and patched this myself.

StargateMC commented 8 years ago

Do share?

ghost commented 8 years ago

http://dev.bukkit.org/bukkit-plugins/otherdrops/files/59-2-8b-596/ - Download that.

Insert this into the script file. > http://pastebin.com/isH0a4LP

This completely stopped all forms of Mining Laser grief.

StargateMC commented 8 years ago

Eh, that's not the mining laser. It also only prevents use of the item, I am trying to allow use of the item & not have it grief.

PS: Check out ItemRestrict. Such a cool tool for what you're doing. Simple too.

Time6628 commented 8 years ago

Normal GriefPrevention does have a Seige feature which is more geared towards pvp, however this is removed in GPP.

StargateMC commented 8 years ago

This is not relavent to the mining laser at all?

Time6628 commented 8 years ago

Was adding to the chat earlier about GP supporting PvP :P http://dev.bukkit.org/bukkit-plugins/grief-prevention/pages/pvp-protection-and-optional-siege-pvp-mode/

sameer commented 8 years ago

Are you using IC2Classic or IC2 Experimental?

StargateMC commented 8 years ago

IC2 Experimental - Classic died years ago no?

sameer commented 8 years ago

Nope, https://github.com/TinyModularThings/IC2Classic

StargateMC commented 8 years ago

To your knowledge is it compatible with the experimental Api? 99% of mods use experimental for integration and might break

sameer commented 8 years ago

Well I know the author tries to keep it integrated but I wouldn't suggest just switching to it, a lot of the items are different.

StargateMC commented 8 years ago

haha fair enough :)

ghost commented 8 years ago

Eh, that's not the mining laser. It also only prevents use of the item, I am trying to allow use of the item & not have it grief.

PS: Check out ItemRestrict. Such a cool tool for what you're doing. Simple too.

faceplam. . .