search

Cyfrin / foundry-full-course-cu

GNU General Public License v3.0
3.72k stars 923 forks source link

.ENV Pledge and keystore management #2203

Closed bxpana closed 3 months ago

bxpana commented 3 months ago

Section

Section 6 | Foundry Simple Storage

Could you please leave a link to the Cyfrin Updraft Lesson (or YouTube video timestamp) where this error occurs? (You can right click a video and "copy video URL at current time")

https://updraft.cyfrin.io/courses/foundry/foundry-simple-storage/private-key-safety-part-2?lesson_format=video

Describe the bug

In the .ENV Pledge it says that Foundry does not have their own keystore creator, but from the Foundry Github issue that @PatrickAlphaC mentioned and https://github.com/foundry-rs/foundry/issues/3818 it seems to be implemented.

If so, then I think the .ENV Pledge and the video should be updated for users to be able to use the Keystore function on Foundry similar to this

bxpana commented 3 months ago

Ok immediately after there is the update video to not use .env files anymore https://updraft.cyfrin.io/courses/foundry/foundry-simple-storage/never-use-a-env-file?lesson_format=video

But I think would still be good to update the pledge

EngrPips commented 3 months ago

Thanks for pointing this out, and it will be attended to appropriately as soon as possible.

PatrickAlphaC commented 3 months ago

Updated :)