JS tests for VariableSearchCtrl, fix bug in search for 'all' values, simplify some code

[stefelisabeth]

• Update existing tests to check starting values
• Simplify code for getting categories in cultural search (api_views.py)
• Fix search for 'all' values for continuous variables
• Prevent multiple calls to MinOrMax in VariableSearchController, prevent values from resetting every time variable is re-selected
• Tests for cultural VariableSearchController

[codecov-io]

Codecov Report

Merging #586 into master will increase coverage by 3.05%. The diff coverage is 88.23%.

@@            Coverage Diff             @@
##           master     #586      +/-   ##
==========================================
+ Coverage   70.33%   73.39%   +3.05%     
==========================================
  Files          41       41              
  Lines        2545     2533      -12     
==========================================
+ Hits         1790     1859      +69     
+ Misses        755      674      -81

Impacted Files	Coverage Δ
...ace_app/static/js/controllers/search/geographic.js	100% <ø> (ø)	:arrow_up:
..._app/static/js/controllers/search/environmental.js	100% <ø> (+11.11%)	:arrow_up:
dplace_app/static/js/models.js	100% <100%> (ø)	:arrow_up:
dplace_app/api_views.py	95.33% <100%> (-0.09%)	:arrow_down:
...place_app/static/js/controllers/search/variable.js	94.02% <83.33%> (+92.64%)	:arrow_up:
...place_app/static/js/controllers/search/cultural.js	100% <0%> (+92.85%)	:arrow_up:

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5ca6bd8...39e2da1. Read the comment docs.

[xrotwang]

@Bibiko are you going to deploy these changes to the production server?

[Bibiko]

@xrotwang not yet - why you're asking?

[xrotwang]

@Bibiko I find it more difficult to diagnose and debug issues with the production site when the deployed code isn't HEAD.