search

D3DEnergetic / FIDASIM

A Neutral Beam and Fast-ion Diagnostic Modeling Suite
http://d3denergetic.github.io/FIDASIM/
Other
27 stars 18 forks source link

Whjh/prefida cocos #253

Closed hayashiw closed 2 years ago

hayashiw commented 2 years ago

PR for review @lstagner Magnetic field COCOS bug fix for geqdsk files

lstagner commented 2 years ago

everything seems fine. Let me know when you want to merge this. I assumed you tested everything out right?

lstagner commented 2 years ago

Also, the clockwise_phi cant be determined by the gfile so it needs to be a required argument for read_geqdsk (its better to throw an error than to have the possibly wrong behavior occur silently) and that change will need to be done to the example in the test directory.

Or at the very least throw a warning that we are assuming a particular direction for phi

hayashiw commented 2 years ago

Also, the clockwise_phi cant be determined by the gfile so it needs to be a required argument for read_geqdsk (its better to throw an error than to have the possibly wrong behavior occur silently) and that change will need to be done to the example in the test directory.

I moved the ccw_phi keyword to be more visible in the arguments for read_geqdsk. I've left it as default = True but still showed it explicitly in run_test.py.