Closed jernejfrank closed 1 month ago
Looks good! Small nits. One thought -- is
@ignore
(the name I suggested) the best name?Other thoughts (would love your ideas):
@hamilton_ignore
@exclude
@hamilton_exclude
And another thought -- should we have an option in
@mutate
andstep
to not ignore them? E.G. is there any way we may want to also include it in the pipeline (instinct says no here...)
Having a look with fresh eyes I agree, we should make it explicit that it is for hamilton to avoid confusion. How about hamilton_skip
?
Looks good! Small nits. One thought -- is
@ignore
(the name I suggested) the best name? Other thoughts (would love your ideas):
@hamilton_ignore
@exclude
@hamilton_exclude
And another thought -- should we have an option in
@mutate
andstep
to not ignore them? E.G. is there any way we may want to also include it in the pipeline (instinct says no here...)Having a look with fresh eyes I agree, we should make it explicit that it is for hamilton to avoid confusion. How about
hamilton_skip
?
Thoughts on naming:
@cache(behavior="ignore")
@ignore
is equivalent to prefixing the function with _
. Instead of the decorator name indicating "what it does" (ignore, exclude), why not indicate "what it is". For consistency with the Hamilton documentation, I would call this @helper
or @utility
because you're indicating that this is a utility function.Other nit:
examples/mutate/abstract functionality blueprint
I think it should be very specific that Hamilton is the one doing it -- so I'm in favor of @hamilton_exclude
.
That said, I don't think this should be the first way to do things (it should be with _
), but there are times it'll be useful (the docs here hit it right, it should show up in the docs, but not in the "How-to" section)
Looks good, let's just change the wording of the docs to indicate that _
is preferred!
Solves #1168.
Changes
mutate
to automatically hide helper functions --> resolved a TODOHow I tested this
step
andmutate
)Checklist