Create tests for `ride-hailing/MessageParams` using jest.

haialaluf commented 5 years ago

first-timers-only

This issue is tagged :octocat: first-timers-only. It is only for people who have never contributed to open source before, and are looking for an easy way take their first steps.

Consider this your chance to dip your toe into the world of open-source, and get some bragging rights for writing code that makes drones fly, lets cars find charging stations, helps people and goods get from place to place, and more.

Find more first-timers-only issues from DAV Foundation here.

Thank you for your help :heart:

What is this project?

DAV (Decentralized Autonomous Vehicles) is a new foundation working to build an open-source infrastructure for autonomous vehicles (cars, drones, trucks, robots, and all the service providers around them) to communicate and transact with each other over blockchain.

As an organization that believes in building a large community of open-source contributors, we often create issues like this one to help people take their first few steps into the world of open source.

dav-js

This SDK enabled integrating any client side JS and NodeJS code with the DAV Network.

How you can help

The Issue

Create tests for ride-hailing/MessageParams using jest.

You need to create tests to check that the serialize and deserialize methods work as expected.

Please use the test file for class NeedParams as a basis for your new code.

Function serialize in class MessageParams must return a JSON object that contains all properties defined in the MessageParams instance.
Function deserialize in class MessageParams receives a JSON string and must initialize all the properties of the MessageParams instance with the values in the JSON string.

messageParams1.desrialize(messageParams2.serialize()) == messageParams2 must therefore always be true.

NOTE: Some names are changed between protocol string representation of instance properties:

location is internally represented as { lat , lon } but serialized as { latitude , longitude }
Private properties are internally prefixed with _ but serialized without the prefix. i.e. _protocol becomes protocol

Contributing to dav-js

[ ] Make sure this issue is labeled up-for-grabs and not labeled claimed, to verify no one else is working on it.
[ ] Comment in this issue that you would like to do it.
[ ] Open dav-js GitHub page and click the ★ Star and then ⑂ Fork buttons.
[ ] Clone a copy to your local machine with $ git clone git@github.com:YOUR-GITHUB-USER-NAME/dav-js.git
[ ] Code Code Code
[ ] Once you've made sure all your changes work correctly and committed all your changes, push your local changes back to github with $ git push -u origin master
[ ] Visit your fork on GitHub.com (https://github.com/YOUR-USER-NAME/dav-js) and create a pull request for your changes.
[ ] Make sure your pull request describes exactly what you changed and references this issue (include the issue number in the title like this: #7)
[ ] Please do not fix more than one issue at a time. Your pull request should only fix what is described in this issue.

Asking for help

We appreciate your effort in taking the time to work on this issue and help out the open source community and the foundation. If you need any help, feel free to ask below or in our gitter channel. We are always happy to help 😄

sallen2 commented 5 years ago

Hello, I would like to work on this issue for you guys!

srfrnk commented 5 years ago

Thanks sallen2. It's yours.

TalAter commented 5 years ago

@sallen2 Are you still interested in doing this one?

Aliciawyse commented 5 years ago

I can do it! I think it'll be good practice to do another. :-)

sallen2 commented 5 years ago

No I apologize I just haven't had time to get to a dude my schedule

On Tue, Oct 2, 2018, 7:13 AM Tal Ater notifications@github.com wrote:

@sallen2 https://github.com/sallen2 Are you still interested in doing this one?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/DAVFoundation/dav-js/issues/32#issuecomment-426235838, or mute the thread https://github.com/notifications/unsubscribe-auth/AaMYtFG1f1m7tPpAXc1v52AiW6-xu2uJks5ug0phgaJpZM4WaZs1 .

TalAter commented 5 years ago

No problem @sallen2 . We have plenty of other issues once you are ready.

Go for it @Aliciawyse !

jmarkham828 commented 5 years ago

I see this is still open – is anyone still working on it? I'd love to get this done for you!

mariolo1985 commented 5 years ago

Hi @jmarkham828 thanks for the interest, let me check.

@Aliciawyse Are you working on this test?

Aliciawyse commented 5 years ago

Whoops, please take it!

mariolo1985 commented 5 years ago

@jmarkham828 this one is all yours 👍

mariolo1985 commented 5 years ago

@jmarkham828 my mistake. After looking over the repo, ride-hailing/MessageParams already have tests created. The changes were merged in this pull request (https://github.com/DAVFoundation/dav-js/issues/94) which is for tests to be created for drone-charging/MessageParams and it is still available. Would you be interested in issue #94?

DAVFoundation / dav-js