DAVFoundation / xplore

⛓ A block explorer for local Ethereum testnets
MIT License
62 stars 65 forks source link

change for loop in getAccounts (first-timers-only) #52

Closed cg-cnu closed 6 years ago

cg-cnu commented 6 years ago

first-timers-only

This issue is tagged :octocat: first-timers-only. It is only for people who have never contributed to open source before and are looking for an easy way take their first steps.

Consider this as your chance to dip your toe into the world of open-source and get some bragging rights for writing code that makes drones fly, cars find charging stations, helps people and goods move from place to place and more...

Find more first-timers-only issues from DAV Foundation here.

Thank you for your help :heart:

What is this project?

DAV (Decentralized Autonomous Vehicles) is a new non-profit foundation working to build an open-source infrastructure for autonomous vehicles (cars, drones, trucks, robots, and all the service providers around them) to communicate and transact with each other over blockchain.

As an organization that believes in building a large community of open-source contributors, we often create issues like this one to help people take their first few steps into the world of open source.

Xplore

The DAV project you are looking at is Xplore. Xplore is a blockchain explorer you can run on your machine to explore local Ethereum nodes on your machine. It is used by developers working with DAV's libraries to ease development and see how the blockchain is affected by their work.

How you can help

The Issue

The task for this issue is to change the for loop in the line https://github.com/DAVFoundation/xplore/blob/master/src/lib/blockchain.js#L37 from for ( let i in accounts)... syntax to for( const account of accounts)... and change the variable usage inside the loop as well!

Contributing to Xplore

Asking for help

We appreciate your effort in taking the time to work on this issue and help out the open source community and the foundation. If you need any help, feel free to ask below or in our gitter channel. We are always happy to help 😄

matepak commented 6 years ago

Hi, I would like to take it.

cg-cnu commented 6 years ago

Congratulations @mateuszs1 on your first opensource contribution! 👏 We hope this is the starting of many 🙂 Feel free to join our [gitter channel] (https://gitter.im/DAVFoundation/DAV-Contributors/)