change syntax loop in blockchain.js issue #53

loic-combis commented 6 years ago

Description

I replaced the line : for (let i in eventContractNames) { By : for (const contractName in eventContractNames) { And removed the line : const contractName = eventContractNames[i];

Related Issue

This pull request is related to the issue #53

Motivation and Context

It makes the code more readable.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

cg-cnu commented 6 years ago

Hey @combisloic Thanks for the contribution. Just a small issue I found here...

The for loop syntax you are supposed to change is from for i in to for i of. You can read about the differences here... for...in and for...of. Just fix it and commit again, it will update the current pr. Let me know if you have any issues! Thanks!

cg-cnu commented 6 years ago

Hey @combisloic Do you need any help in pushing this one out! Let me know! Thanks!

DAVFoundation / xplore