DBCDK / dk5

DK5 Digital
GNU Affero General Public License v3.0
0 stars 0 forks source link

An in-range update of eslint is breaking the build 🚨 #340

Closed greenkeeper[bot] closed 6 years ago

greenkeeper[bot] commented 7 years ago

Version 4.8.0 of eslint just got published.

Branch Build failing 🚨
Dependency eslint
Current Version 4.7.2
Type devDependency

This version is covered by your current version range and after updating it in your project the build failed.

As eslint is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this :muscle:

Status Details - ❌ **continuous-integration/travis-ci/push** The Travis CI build failed [Details](https://travis-ci.org/DBCDK/tanterne/builds/281478245?utm_source=github_status&utm_medium=notification)

Release Notes v4.8.0
  • 3f2b908 New: add option to report unused eslint-disable directives (fixes #9249) (#9250) (Teddy Katz)
  • ff2be59 Fix: dot notation rule failing to catch string template (fixes #9350) (#9357) (Phil Quinn)
  • b1372da Chore: remove sourceCode property from Linter (refs #9161) (#9363) (Teddy Katz)
  • cef6f8c Docs: remove line about removing rules from semver policy (#9367) (Teddy Katz)
  • 06efe87 Fix: Add meta element with charset attribute. (#9365) (H1Gdev)
  • 458ca67 Docs: update architecture page (fixes #9337) (#9345) (Victor Hom)
  • 1c6bc67 Fix: special EventEmitter keys leak information about other rules (#9328) (Teddy Katz)
  • d593e61 Docs: update eslint.org links to use https (#9358) (Teddy Katz)
  • 38d0cb2 Fix: fix wrong code-path about try-for-in (fixes #8848) (#9348) (Toru Nagashima)
  • 434d9e2 Fix: Invalid font-size property value issue. (#9341) (H1Gdev)
  • a7668c2 Chore: Remove unnecessary slice from logging utility (#9343) (Gyandeep Singh)
  • 2ff6fb6 Chore: remove unused arguments in codebase (#9340) (Teddy Katz)
Commits

The new version differs by 14 commits.

  • 8ebb034 4.8.0
  • 916a2d7 Build: changelog update for 4.8.0
  • 3f2b908 New: add option to report unused eslint-disable directives (fixes #9249) (#9250)
  • ff2be59 Fix: dot notation rule failing to catch string template (fixes #9350) (#9357)
  • b1372da Chore: remove sourceCode property from Linter (refs #9161) (#9363)
  • cef6f8c Docs: remove line about removing rules from semver policy (#9367)
  • 06efe87 Fix: Add meta element with charset attribute. (#9365)
  • 458ca67 Docs: update architecture page (fixes #9337) (#9345)
  • 1c6bc67 Fix: special EventEmitter keys leak information about other rules (#9328)
  • d593e61 Docs: update eslint.org links to use https (#9358)
  • 38d0cb2 Fix: fix wrong code-path about try-for-in (fixes #8848) (#9348)
  • 434d9e2 Fix: Invalid font-size property value issue. (#9341)
  • a7668c2 Chore: Remove unnecessary slice from logging utility (#9343)
  • 2ff6fb6 Chore: remove unused arguments in codebase (#9340)

See the full diff

Not sure how things should work exactly? There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html) and of course you may always [ask my humans](https://github.com/greenkeeperio/greenkeeper/issues/new).

Your Greenkeeper Bot :palm_tree:

greenkeeper[bot] commented 7 years ago

After pinning to 4.7.2 your tests are still failing. The reported issue might not affect your project. These imprecisions are caused by inconsistent test results.

fvsdbc commented 6 years ago

Fixed