search

DCBIA-OrthoLab / SlicerAutomatedDentalTools

A 3D Slicer extension to use AMASSS, ALI-CBCT and ALI-IOS
Other
79 stars 22 forks source link

ENH: AutoCrop3D add option to UI BUG: error import ASO and __init__ from Automatrix solved #60

Closed Jeanneclre closed 6 months ago

Jeanneclre commented 6 months ago

Hello @allemangD

It should be better to understand now (Hopefully). I thought it was better to rebase everything in the main branch and not asking a PR per branch.

Please tell me if I need to change anything.

Thank you very much!

allemangD commented 6 months ago

I've rebased the changes and force-with-lease pushed to this PR branch. The old contents of the PR are now in branch old-pr-60 https://github.com/DCBIA-OrthoLab/SlicerAutomatedDentalTools/tree/old-pr-60

Note there is no diff between the new and old pr branches: https://github.com/DCBIA-OrthoLab/SlicerAutomatedDentalTools/compare/7cfca374d6dd858daa0a6fbfa0946e7815271a79..727f6c3e07dacda3f74ca65d28094342fca35e64 and note that only the minimal list of commits are included in this PR.

@Jeanneclre - since this PR branch was your main branch, it was probably bad etiquette for me to force push to it, so I apologise.

Since the current and previous state are identical, with extraneous commits removed, you must use the command git pull --rebase to update your main to be in-sync with this branch. In the future I suggest you create separate branches for PRs, so that if the reviewer needs to edit the PR it won't modify your main.

allemangD commented 6 months ago

The same pattern you've done of renaming Methode to Method and of adding __init__.py on Python modules was still missing in other parts of the extension. I added 0894740 and 56015b0 to do these across the entire extension, so these import errors should not occur in the future.

I suggest you also test before merging to ensure I haven't introduced any regressions with this.

Jeanneclre commented 6 months ago

Noted! I did a test, it doesn't seem to have introduced any regressions and I don't see any errors so that's fine for me. Thanks :)