search

DCBIA-OrthoLab / SlicerAutomatedDentalTools

A 3D Slicer extension to use AMASSS, ALI-CBCT and ALI-IOS
Other
79 stars 22 forks source link

ENH/STYLE: Correct packages installation for CBCT or IOS #80

Closed Jeanneclre closed 5 months ago

Jeanneclre commented 5 months ago

Good Morning @allemangD

AREG calls all the other modules, AMASS, ASO, and ALI, so we think it is better to install all required libraries for them. I splitted IOS from CBCT because pytorch3d is not needed for CBCTs.

The message of the pop-up window is the following - I am not sure about the last line:

The following changes are required for the libraries:
--- Libraries to update (version mismatch):
library one (current version)--> <new version>

--- Libraries to install: 
library two <version_constraint>

Do you agree to modify these libraries? Doing so could cause conflicts with other installed Extensions.
(If you are using other extensions, consider downloading another Slicer to use AutomatedDentalTools exclusively.)

Thank you

allemangD commented 5 months ago

Did you intend to check these patch files into the repo? I assume these should be removed.

0001-STYLE-function-to-install-required-libraries.patch
0002-Style-combine-all-packages-installation-in-AREG.py.patch
0003-ENH-split-call-to-install-function-for-IOS-and-CBCT.patch
0004-ENH-pytorch3d-version-specified.patch

Otherwise the changes look fine, with the same caveat I mentioned in https://github.com/DCBIA-OrthoLab/SlicerAutomatedDentalTools/pull/79#pullrequestreview-1849840551 (also applies to #75 but I did not mention it there).