search

DCBIA-OrthoLab / SlicerAutomatedDentalTools

A 3D Slicer extension to use AMASSS, ALI-CBCT and ALI-IOS
Other
79 stars 22 forks source link

ENH : add ALI_IOS on windows with SlicerConda #86

Closed GaelleLeroux closed 3 months ago

GaelleLeroux commented 3 months ago

Hi @allemangD !

I've made ALI_IOS running on Windows using SlicerConda. Can you give me review and/or merge it if it's ready to be merge ?

Thank you ! Gaelle

allemangD commented 3 months ago

You'll need to add SlicerConda as a dependency to CMakeLists and to each scripted loadable module that now uses it.

https://github.com/DCBIA-OrthoLab/SlicerAutomatedDentalTools/blob/main/CMakeLists.txt#L13

https://github.com/DCBIA-OrthoLab/SlicerAutomatedDentalTools/blob/main/ALI/ALI.py#L152

Otherwise the changes make sense and should be fine. Thanks!

GaelleLeroux commented 3 months ago

@allemangD

I made the change, can you merge it if it's good ?

Thank you ! :)

GaelleLeroux commented 3 months ago

@allemangD

Okay thank you for the explanation ! I tried to make the changes again, are they good ? I changed SlicerAutomatedDentalTools.s4ext and create a pull request here