search

DCC-EX / Support-Planning

DCC++EX Repo to hold project planning documentation and processes
1 stars 1 forks source link

Ticket Submitted - Emergency Stop Issue #33

Closed fire-bot closed 3 years ago

fire-bot commented 3 years ago

Sent by (mkakasapu@gmail.com). Created by fire.

Michael created a ticket

Name: MichaelHochmuth

Email: pappmodell@arcor.de

Timezone: 1

Software: CommandStationEx

Version: 3.0.0

Title: Emergency Stopp does not work

Description: I'm running DCC++ at Rocrail in combination with Locobuffer and Loconet-Throttle FREDI from FREMO. I have also the Commandstation SPROG3 in use. At DCC++ i had detected, that emergency stop does not work. So I searched the code and found a place in PacketRegister.cpp which I had changed. Now the emergency stop worked with DCC++: line 121 from: b[nB++]=tSpeed+(tSpeed>0)+tDirection128; to: b[nB++]=tSpeed+(tSpeed>1)+tDirection128; Speed 0 = Stop Speed 1 = Emergency Stop Now I have installed the code for Command Station EX and there also the emergency stop is not working. I can see in Rocrail, that Speed=1 is send to the Command-Station, if I press the "Emergency Stop" at the FREDI-Controller. Can you please realize the emergency stop also at DCC-EX. Regards Michael.

Remaining email Quota: 100

Asbelos commented 3 years ago

The DCCEX code uses the value -1 to represent emergency stop (DCC speed 1) because it must keep backward compatibility with DCC++ , JMRI and the original documented commands. It appears from your comments that Rocrail is not following the comnand language correctly.

FrightRisk commented 3 years ago

This is a Rocrail issue. Closing for now. If RR won't fix the bug, we may be able to have a config.h fix or similar where we have "rockrail_fix" that can be turned on