DCMLab / reductive_analysis_app

Web app for reductive analyses of scores
https://dcmlab.github.io/reductive_analysis_app/
Other
15 stars 4 forks source link

Note bookmarks and naturalize #216

Closed meduzen closed 2 years ago

meduzen commented 2 years ago

Closes #168.

(Don’t forget to npm install.)

Also:

yrammos commented 2 years ago

@meduzen

The new tooltip looks very much improved. But switching between overlapping relations (using z) does not update the tooltip text as it should.

"Naturalizing" does works — thank you!

yrammos commented 2 years ago

@meduzen I am facing issues with bookmarking.

With certain files, bookmarking works, albeit only via the UI (not the keyboard shortcut).

With other files, the keyboard shortcut is triggered, but an error pops up:

Can't find variable: add_bookmark

pettter commented 2 years ago

I'm trying to reproduce @yrammos issues, and found that

Re: the keyboard shortcut, I'll push a fix - replacing add_bookmark with bookmarks.toggle at the relevant position in ui.js

After some trials I can't seem to reproduce it not working - what files did you have trouble with @yrammos ?