DCMLab / reductive_analysis_app

Web app for reductive analyses of scores
https://dcmlab.github.io/reductive_analysis_app/
Other
15 stars 4 forks source link

Add license banner to all files. #218

Closed yrammos closed 2 years ago

yrammos commented 2 years ago

This PR addresses #206:

find . -name '*.js' -print0 | xargs -0 sed -i '' "1s/^/\/\*\n${LICENSE_BANNER}"

Developers will need to manually prepend the license banner to any new javascript source files from now on. (This is because the rollup plugin acts on automatically generated javascript only, not on source.)

meduzen commented 2 years ago

I pushed a commit to fix my name.

FYI, when I build the app (running npm run build), the public/assets/dependencies.txt file gives me a slightly different result then the one in this PR.

Instead of this:

---

Name: pagemap
Version: 1.4.0
License: MIT
Private: false
Description: Mini map for web pages.
Repository: git+https://github.com/lrsjng/pagemap.git
Homepage: https://larsjung.de/pagemap/
Author: Lars Jung <lrsjng@gmail.com> (https://larsjung.de)

I have this:

---

Name: pagemap
Version: 1.4.0
License: MIT
Private: false
Description: Mini map for web pages.
Repository: https://github.com/lrsjng/pagemap.git
Author: Lars Jung <lrsjng@gmail.com> (https://larsjung.de)

Differences:

I don’t think it’s important, but it’s still unexpected.

I see the package-lock.json is now in “v1”. Could it be that you installed and ran it on Node < 14 and/or on NPM < 7? 🤔

yrammos commented 2 years ago

@meduzen I had built this with node 14.19.1 and npm 8.7.0.

Rebuilding with node 16, I get the same pagemap attribution as I did earlier. I cannot explain this small discrepancy between our two outputs, but I think we may safely ignore it.