Liquescents not working

[JoyfulGen]

Liquescents on Neon aren't getting their curve attribute, so they're being recorded as puncta. If you change a note head to a liquescent C or A, or if you input a liquescent C or A, it'll look fine at first, but if you reload the page the liquescents will become puncta. In the MEI file, the note looks like a punctum (I think), even though you made it a liquescent.

This is a slightly urgent issue, because I've found no other way to add liquescents to a file at the moment.

[yinanazhou]

Working on it!

[yinanazhou]

Hi @JoyfulGen, to follow up your question about liquescent not showing up, it is because we were encoding liquescent wrong before.

Before liquescent is encoded as:

<neume>
    <nc oct="2" pname="d" tilt="n"/>
    <nc oct="2" pname="c" curve="a" />
</neume>

But it should be:

<neume>
    <nc oct="2" pname="d" tilt="n"/>
    <nc oct="2" pname="c" curve="a">
        <liquescent />
    </nc>
</neume>

After I fixed this in verovio, the liquescents in the old files won't show up because <nc> doesn't have a <liquescent>, so verovio doesn't know which note type it should be. I will push a temporary fix in Neon to automatically add <liquescent> when the <nc> has a curve value. And we also need to fix this in the MEI encoding job in Rodan.

[yinanazhou]

Hi @JoyfulGen, I've pushed the changes. Liquescents should be good now.

[JoyfulGen]

@yinanazhou indeed you have, thank you! It all looks good.

About the mei_encoding problem, I have question: in the csv file I use for the mei_encoding job, liquescents do have the <liquescent> attribute. But when files come out of OMR, they don't have the attribute. So the issue is in the mei_encoding job itself, right?

[JoyfulGen]

@PhoebeDM liquescents are good now!

[fujinaga]

@yinanazhou indeed you have, thank you! It all looks good.

About the mei_encoding problem, I have question: in the csv file I use for the mei_encoding job, liquescents do have the <liquescent> attribute. But when files come out of OMR, they don't have the attribute. So the issue is in the mei_encoding job itself, right?

@yinanazhou, can you work with @timothydereuse to resolve this? Perhaps create a separate issue in MEI_encoding?

[yinanazhou]

@yinanazhou, can you work with @timothydereuse to resolve this? Perhaps create a separate issue in MEI_encoding?

Will do!

[yinanazhou]

Corresponding Rodan issue: https://github.com/DDMAL/Rodan/issues/1123

[PhoebeDM]

Hiya @yinanazhou and @JoyfulGen, liquescents aren't working again/reverting to puncta...I'm in 151r, anything I should try?

[yinanazhou]

@PhoebeDM I probably mixed verovio versions. I will quickly update it and let you know when it's done!

[yinanazhou]

Hi @PhoebeDM I've pushed the changes. It should be good now.

[JoyfulGen]

@yinanazhou liquescents work!