DECAF / wordpress_mailtostaff

WordPress plugin: mailto:staff
http://wordpress.org/plugins/mailtostaff/
0 stars 1 forks source link

Outlook delimiter #1

Open wilmy048 opened 9 years ago

wilmy048 commented 9 years ago

Although RFC specification for email list clearly specifies comma delimiter, Windows/Microsoft had to be different and use ';'. So, you should add to your code a check if the operating system is Windows and of it is, use the ";" as a delimiter, otherwise use ",". Here is the code for it:

In a separate file have a 'detector' and then by including the file, you can use the values in the '$os' variable to determine the operating system. $agent = $_SERVER['HTTP_USER_AGENT'];

if(preg_match('/Linux/',$agent)) $os = 'Linux'; elseif(preg_match('/Win/',$agent)) $os = 'Windows'; elseif(preg_match('/Mac/',$agent)) $os = 'Mac'; else $os = 'UnKnown';

I have tried doing it in your plugin, but for some reason I can't get this to display the ; even though it is detecting windows OS, when I output the value of $os variable. Weird.

schuer commented 9 years ago

@wilmy048 thanks for your support!

Checking for Windows won't be a good approach if the issue is caused by Outlook. Windows user are not bound to use Outlook and Outlook users are not bound to use Windows.

As we cannot detect Outlook, we don't spot a solution for this issue. It's up to the user to configure the system according to RFC: http://support.microsoft.com/kb/820868

Maybe we should add a note to the plugin's readme.

wilmy048 commented 9 years ago

Sure, I understand this and it makes sense☺

From: Dirk Schürjohann [mailto:notifications@github.com] Sent: Friday, 31 October 2014 3:26 AM To: DECAF/wordpress_mailtostaff Cc: Williams, Maja - wilmy048 Subject: Re: [wordpress_mailtostaff] Outlook delimiter (#1)

@wilmy048https://github.com/wilmy048 thanks for your support!

Checking for Windows won't be a good approach if the issue is caused by Outlook. Windows user are not bound to use Outlook and Outlook users are not bound to use Windows.

As we cannot detect Outlook, we don't spot a solution for this issue. It's up to the user to configure the system according to RFC: http://support.microsoft.com/kb/820868

Maybe we should add a note to the plugin's readme.

— Reply to this email directly or view it on GitHubhttps://github.com/DECAF/wordpress_mailtostaff/issues/1#issuecomment-61127479.