DEIB-GECO / GMQL

GMQL - GenoMetric Query Language
http://www.bioinformatics.deib.polimi.it/geco/
Apache License 2.0
18 stars 11 forks source link

Enable DEFAULT() option for semijoin/joinby/groupby conditions #77

Closed sunbrn closed 7 years ago

sunbrn commented 7 years ago

I have verified that:

Also this last option should be enabled.

@pp86

marcomass commented 7 years ago

@pp86 The 4 options above applies on all the following operators:

pp86 commented 7 years ago

What should DEFAULT do?

sunbrn commented 7 years ago

@pp86, the semantics of DEFAULT is the same of not specifying anything.

E.g., C = SELECT(semijoin: cell_type IN B) A; must produce the same effect as C = SELECT(semijoin: DEFAULT(cell_type) IN B) A;

marcomass commented 7 years ago

@pp86 The syntax reported above by Anna is the one that you defined time ago, in which DEFAULT() acts as alone. You already implemented this behavior for some operators (I think merge, join, map; to be checked), but nor for others. Please make implementation consistent, implementing it for all operators where it should apply, or removing it from all operators (leaving for the same behavior only ).

As well FULLNAME() could be simplified into FULL(), similarly to EXACT().

pp86 commented 7 years ago

FULLNAME renamed to FULL.

Default is never used, please remove from the documentation if mentioned.