search

DFE-Digital / academy-transfers-frontend

Academy Transfers frontend proof of concept, a part of the Schools Delivery Division. Talks to https://github.com/DFE-Digital/academy-transfers-api
MIT License
1 stars 1 forks source link

Branching not working. #27

Open ghost opened 3 years ago

ghost commented 3 years ago

The 'Yes' , 'No' branching on page: https://academy-transfers-prototype-frontend.london.cloudapps.digital/trusts/617be920-eaa0-e911-a83f-000d3a3852a3/incoming

Does not work both options take you to pick an incoming trust at page: https://academy-transfers-prototype-frontend.london.cloudapps.digital/trusts/617be920-eaa0-e911-a83f-000d3a3852a3/incoming/identified

There should be a direct to summary page path once you've selected 'No'.

reggieb commented 3 years ago

This was discussed, and the change was put into this PR which you approved: https://github.com/DFE-Digital/academy-transfers-frontend/pull/24

My understanding from the discussions was that in the situation where a single trusts is not identified as THE incoming trusts, the user needed to select the multiple trusts that are potential incoming trusts. So the user needs to go to the trust selection either way.

This is probably my mistake, as I have no understanding of the purpose of this page.

ghost commented 3 years ago

My bad, I definitely have to set this up locally so I can test before reviewing.

I must be missing some context here as I thought there would be a use case where the incoming trust has not been identified yet.

Apologies, I didn't mean to to drag you in. Let's figure this out Monday. Enjoy your weekend.

ghost commented 3 years ago

This is why documentation over discussions wins. We'll leave #27 as it is and then potentially remove the identified page all together from the app.

We really need Basecamp. Rather than everything else...