search

DFHack / df-structures

Dwarf Fortress data structure descriptions
https://github.com/DFHack/dfhack
118 stars 81 forks source link

Add "All" group attr to new unit_action_type enums #792

Closed Bumber64 closed 3 months ago

Bumber64 commented 4 months ago

Add enum attrs so all unit_action_type enums are in the All unit_action_type_group.

They may also need attrs for Movement, MovementFeet, Combat, and/or Work (however we decide that).

myk002 commented 4 months ago

are these types handled by the action timers API in Units.cpp?

Bumber64 commented 4 months ago

are these types handled by the action timers API in Units.cpp?

Looks like HoldItem, Mount, and Dismount are?

ReleaseItem, LeadAnimal, and StopLeadAnimal return nullptr for getActionTimerPointer. So do Jump, ReleaseTerrain, Parry, and Block, despite already being in the All group.

myk002 commented 4 months ago

ok, if there are no additional timers to handle, then this looks good to me. will merge after @quietust approves

myk002 commented 3 months ago

seems ok -- @quietust please tell me if you have any comments