DFHack / dfhack

Memory hacking library for Dwarf Fortress and a set of tools that use it
Other
1.84k stars 463 forks source link

Steam engine doesn't work in adventure mode #1720

Open Tachytaenius opened 3 years ago

Tachytaenius commented 3 years ago

The water that gets put in has no temperature, and if I gm-editor its temperature up, the engine still doesn't move. Well, unless max temp was too much...?

Tachytaenius commented 3 years ago

Using default raws found in that example file somewhere.

tried to stoke boiler using advfirt

warmist commented 3 years ago

Just a guess: it could be that reaction does not trigger script if not in fort mode.

Probably this line: https://github.com/DFHack/dfhack/blob/develop/plugins/steam-engine.cpp#L985

lethosor commented 3 years ago

The fortress mode check was added in https://github.com/DFHack/dfhack/commit/6187ac30544a81b39cf207ccaedb1aa4dc5a7d59 to fix an arena-related crash, but I don't know if siege-engine worked in adventure mode previously (although I doubt it was intended to).

Using default raws found in that example file somewhere.

Just to clarify, that is https://github.com/DFHack/dfhack/blob/develop/plugins/raw/building_steam_engine.txt, right?

Tachytaenius commented 3 years ago

oops. thought i had said yes D: