Closed EdoStorm96 closed 1 year ago
@tymees I did notice that the change to
https
in thehandle_field_file
function of theRowValueClass
causes an error in my browser when clicking links in the pdf, with the error code: SSL_ERROR_RX_RECORD_TOO_LONGHowever, Django tells me this is because the development server only support http:
You're accessing the development server over HTTPS, but it only supports HTTP.
So it will be fine on the production server?
I'll look at this PR tomorrow in-depth. But for now:
Yeah, it's because local dev doesn't have https. Normally, you'd solve this by retrieving the used protocol (http vs https) from the request object; but PDF gen doesn't (always) have access to that.
It will be fine on the server, those are HTTPS only. You could maybe create an if on the DEBUG setting, but I don't have any strong opinions tbh
Fix for issue #572. I got rid of now obsolete pdf templates and made sure the pre-assessment and pre-approval proposals are properly incorporated in the new PDF workflow.
Maybe the
pdf_template_name
function can be removed entirely? I guess it is not being used in this version. What do y'all think?@tymees I did notice that the change to
https
in thehandle_field_file
function of theRowValueClass
causes an error in my browser when clicking links in the pdf, with the error code: SSL_ERROR_RX_RECORD_TOO_LONGHowever, Django tells me this is because the development server only support http:
You're accessing the development server over HTTPS, but it only supports HTTP.
So it will be fine on the production server?