Closed ewamiti closed 4 years ago
I will look at it within the next few weeks, but cannot promise a time yet.
If you can get started with the implementations, @ewamiti, I can probably much faster help you debugging and we can get this done a lot quicker.
I have developed this for Topographic phase removal. Will this work?
Topographic Phase Removal s1tbx_Topographic_Phase_Removal Topographic Phase Removal Radar ParameterRaster|sourceProduct|Input image|False|False ParameterSelection|demName|The digital elevation model|ACE2_5Min;ACE30;ASTER 1sec GDEM;GETASSE30;SRTM 1Sec Grid;SRTM 1Sec HGT;SRTM 3Sec;External DEM|6 ParameterFile|externalDEMFile|External DEM file|False|True ParameterNumber|externalDEMNoDataValue|External DEM no-data value|None|None|0.0 ParameterBoolean|externalDEMApplyEGM|Apply Earth Gravitational MOdel to external DEM|False ParameterNumber| topoPhaseBandName | topoPhaseBandName OutputRaster|-out|Output Image
Looks very good. Did you try running it?
Not important at all: The other algorithms use dashes -
to separate words, so that would be s1tbx_Topographic-Phase-Removal
.
@ewamiti, a couple more things:
Otherwise looks good :)
@ewamiti If it is not too much trouble, please consider updating SNAP to the latest version and writing the implementations against that version. You can update with Help > Check for Updates
.
@j08lue @radosuav Look at inputs from your comments below.
TopoPhaseRemoval s1tbx_Topographic-Phase-Removal Topographic Phase Removal Radar ParameterRaster|sourceProduct|Input image|False|False ParameterNumber|orbitDegree|Orbit Interpolation Degree|None|None|3 ParameterSelection|demName|The digital elevation model|ACE2_5Min;ACE30;ASTER 1sec GDEM;GETASSE30;SRTM 1Sec Grid;SRTM 1Sec HGT;SRTM 3Sec;External DEM|6 ParameterFile|externalDEMFile|External DEM file|False|True ParameterNumber|externalDEMNoDataValue|External DEM no-data value|None|None|0.0 ParameterBoolean|externalDEMApplyEGM|Apply Earth Gravitational MOdel to external DEM|False ParameterBands| topoPhaseBandName | Topo Phase Band Name||sourceProduct|True OutputRaster|-out|Output Image
What i was not sure about is how to include the percentages on 'tile extension' so that i can choose from the drop down listing. The topo Phase Band Name on SNAP is a constant name 'topo_phase'
@ewamiti looks good, you should copy it to C:\Users\YOUR_USERNAME.qgis2\python\plugins\processing_gpf\s1tbx_description, restart QGIS and try running the algorithm. If something is not correct it will print the error message in the log tab of the Processing dialog.
For the tile extension you can use ParameterSelection to obtain drop down list.
I can not get INSAR-Coregistration on my SNAP. What could be the problem?
Another question is how do i add a check box in Goldstein phase filtering for choosing 'Use Coherence Mask'
I did this for Goldstein Phase Filtering
GoldsteinPhaseFiltering s1tbx_Goldstein-Phase-Filtering Goldstein Phase Filter Radar ParameterRaster|sourceProduct|The product which will be Filtered|False|False ParameterBands|sourceBands|The list of source bands||sourceProduct|True ParameterNumber|alpha|alpha|0|1|1.0 ParameterSelection|FFTSizeString|FFT Size|32;64;128;256|64 ParameterSelection|windowSizeString|Window Size|3;5;7| ParameterBoolean|useCoherenceMask|Use Coherence Mask|False ParameterNumber|coherenceThreshold|Coherence Threshold|0|None|0.2 OutputRaster|-out|Output Image
I was able to note from step forum that INSAR coregistration and Automatic Coregistration were merged. Also i noted that this is a group of processes which are in QGIS already.
At the moment my challenge is SNAPHU export and import. These seems like flows and i don't get the parameters to set up a processing -gpf file for QGIS. Please help.
I have no experience with SNAPHU, but judging from a quick search it seems like you might need to wrap this task into a full GPT graph and interface that (see https://github.com/DHI-GRAS/processing_gpf/tree/GW-A_dev/gpf_models for examples). - (@radosuav had a better solution.)
For the other implementations you are making, you could perhaps make a pull request that you keep adding to (fork this repo, push to your fork, then create pull request). It makes it is easier to test your changes and comment.
I also have no experience with SNAPHU but I think that adding import and export should be a two step process:
The first step should be easy, similar to adding any other operator (e.g. the TopoPhaseRemoval). Unfortunately, the option to display the operator parameters is not available when accessing the algorithm from Radar > Interferometric > Unwrapping on the SNAP main menu. But you can go to Tools > Graph Builder and then File > Load Graph and select SnaphuExportGraph.xml or SnaphuImportGraph.xml from C:\Users_username.snap\graphs\internal\insar and finally view the parameters under File > View Graph XML.
The second step can be achieved in the QGIS. In the Processing Toolbox go to SNAP Toolbox > Tools > Create new model.
Thanks for the direction @radosuav I can get the snaphu import operator parameters but i can not actually get how to create a model from them. Can you briefly guide me. Thank you
The GPF modeler is based on the QGIS Processing Modeler so you should be able to learn how to create a model from this tutorial. Just replace the first step by the screenshot below to launch the GPF modeller:
One major difference from Processing models is that in GPF models all raster inputs have to be read by the Read operator and all raster outputs have to be written by the Write operator.
I would like to add the following SNAP processes to SNAP.