DIRACGrid / DIRAC

DIRAC Grid
http://diracgrid.org
GNU General Public License v3.0
112 stars 174 forks source link

TargetSE field length is limited to 255 in RedDB.Operation #3302

Closed vbpnl closed 6 years ago

vbpnl commented 7 years ago

https://github.com/DIRACGrid/DIRAC/blob/ca83ff46792fe4b35540913de7bd82f2af3e50f0/RequestManagementSystem/DB/RequestDB.py#L72

mysql> SELECT * FROM Operation WHERE OperationID=4272529 LIMIT 1; | TargetSE | CreationTime | SourceSE | Arguments | Error | Type | Order | Status | LastUpdate | SubmitTime | Catalog | RequestID | OperationID |

| MPPMU-TMP-SE,DESY-TMP-SE,McGill-TMP-SE,KIT-TMP-SE,Napoli-TMP-SE,Frascati-TMP-SE,HEPHY-TMP-SE,CNAF-TMP-SE,Melbourne-TMP-SE,KEK-DISK-TMP-SE,ULAKBIM-TMP-SE,SIGNET-TMP-SE,CYFRONET-TMP-SE,UVic-TMP-SE,CESNET-TMP-SE,Roma3-TMP-SE,KMI-TMP-SE,Torino-TMP-SE,KISTI-TM | 2017-04-02 23:30:30 | NULL | NULL | unknown targetSE: KISTI-TM | RemoveReplica | 2 | Waiting | 2017-04-02 23:30:30 | 2017-04-02 23:30:30 | NULL | 2171005 | 4272529 |

--

Notice that TargetSE field is truncated with KISTI-TM because it is limited to 255 char

Can this be fixed?

chaen commented 7 years ago

How do you want it fixed ? You can just operationally increase the column size on your DB

fstagni commented 7 years ago

The increased field length can be persisted in the code, but anyway you can/should do a "manual intervention" on the DB side. Increasing is always safe.

Regarding persisting it in the code: may I ask you to do the PR by yourself? Thanks.

chaen commented 7 years ago

I am not in favour of putting huge values by default. The use case of having 42 targetSE seems pretty seldom to me, but I might be wrong.

fstagni commented 7 years ago

Are there updates on this?

fstagni commented 6 years ago

No updates, and an operational issue. Closing.