DISTRHO / Cardinal

Virtual modular synthesizer plugin
https://cardinal.kx.studio/
GNU General Public License v3.0
2.07k stars 141 forks source link

BUG?: Cardinal does not notify host of patch changes, allowing host to exit without warning user of unsaved changes. #631

Open taji opened 3 months ago

taji commented 3 months ago

Host: Reaper v6.34 Cardinal: 23.10 Pop OS (Linux)

To reproduce:

NOTE: Following the steps above in VCV will cause Reaper to warn you before exiting. I think the difference is that when adding a module, VCV is updating a VST parameter and notifying Reaper of the change. This way Reaper knows to warn the user that his changes are unsaved.

taji commented 2 months ago

An update:

So my thinking is that this issue is now fixed to the point where it mostly works. You can close this issue as resolved.

dromer commented 2 months ago

We didn't change anything to this regard.

Did you perhaps connect the Host Params module, or something equivalent from the Cardinal Host modules? These parameters register with the host when you connect them, so it could be that Reaper detected this and now will warn about changes made to the plugin.

taji commented 2 months ago

@dromer , yes you are right. I did exactly that! I went back and tested again with just a simple LFO into SCOPE and the problem is still there. So I guess we keep it open? I am happy to test if/when you have a fix for this.