search

DIYBookScanner / spreadpi

Raspberry Pi image for controlling a DIYBookScanner via spreads
GNU General Public License v2.0
37 stars 11 forks source link

spread daemon dies if no devices found, will not automatically restart #10

Closed matti-kariluoma closed 10 years ago

matti-kariluoma commented 10 years ago

I started up a pi using an image built from these scripts. I booted it up, and everything started fine, except spreads immediately died because my cameras weren't plugged in! I had to manually start it after the cameras had been turned on.

Something I haven't tested, but will probably lead to similar results: what happend if I unplug a camera while the spreads daemon is running? will it die then too?

jbaiter commented 10 years ago

I started up a pi using an image built from these scripts. I booted it up, and everything started fine, except spreads immediately died because my cameras weren't plugged in! I had to manually start it after the cameras had been turned on.

Yes, this is a bug that's there since I added the code to display the address on the camera displays on startup. I should probably make that depend on whether the cameras are turned on or not. Will be fixed!

Something I haven't tested, but will probably lead to similar results: what happend if I unplug a camera while the spreads daemon is running? will it die then too?

No, upon the next action that would be delegated to that device, the driver will notice that it no longer lives at that USB address and seek for a device with an identical serial number on a different bus/address and store that reference if it is found. If no replacement device is found, it will log a warning (that should be displayed in the UI) and inform the user to take appropriate action.

markvdb commented 10 years ago

Checked and fixed.