Open george-cosma opened 1 month ago
Problem no. 2 is still not solved.
Also, there is another issue. The main deployment mechanism seems to be failing: https://github.com/DLR-FT/wasm-interpreter/actions/workflows/pages_deploy_main.yaml It seems to be failing due to some sort of branch protection rule.
There are currently 2 outstanding issues with the PR preview system:
coverage
tag is added. However, the action which makes the "publishing" of these preview possible isrossjrw/pr-preview-action@v1.4.7
doesn't recognize thelabeled
action as something it needs to act upon. As such it skips the event. It generates the report after another commit is made/ the branch is force-pushed. I can see only a handful of ways to fix this: i. Open an issue on the repository and wait for a fix. It might take a long time ii. Fork the action and modify it ourselves. This will take time away from working on the interpreter. iii. Somehow work around it. Currently I have no idea how. iv. Change the coverage report to be generated if thetests
directory has a modification. (Or perhaps iftests
orsrc
is modified). I talked about it with @valexandru , and I think we had a reason why we wanted it on-demand but my memory fails me right now.