search

DLR-FT / wasm-interpreter

A minimal in-place WebAssembly interpreter, written in Rust, almost without use of external dependencies
https://dlr-ft.github.io/wasm-interpreter/main/
Apache License 2.0
3 stars 2 forks source link

BUG: PR Previews have some rough edges #45

Open george-cosma opened 1 month ago

george-cosma commented 1 month ago

There are currently 2 outstanding issues with the PR preview system:

  1. For the coverage report preview, the report should be created only when the coverage tag is added. However, the action which makes the "publishing" of these preview possible is rossjrw/pr-preview-action@v1.4.7 doesn't recognize the labeled action as something it needs to act upon. As such it skips the event. It generates the report after another commit is made/ the branch is force-pushed. I can see only a handful of ways to fix this: i. Open an issue on the repository and wait for a fix. It might take a long time ii. Fork the action and modify it ourselves. This will take time away from working on the interpreter. iii. Somehow work around it. Currently I have no idea how. iv. Change the coverage report to be generated if the tests directory has a modification. (Or perhaps if tests or src is modified). I talked about it with @valexandru , and I think we had a reason why we wanted it on-demand but my memory fails me right now.
  2. If a coverage report and a requirement preview is requested at the same time, only one link will be displayed in the preview message. This is once again a limitation of the action. I can see only a handful of ways to fix this: i. Open an issue on the repository and wait for a fix. It might take a long time ii. Fork the action and modify it ourselves. This will take time away from working on the interpreter. iii. Somehow work around it. Currently I have no idea how.
  3. Only accessible through the PR. I don't know if this is a massive issue, but thought I'd mention it, as a limitation.
george-cosma commented 1 month ago

Problem no. 2 is still not solved.

Also, there is another issue. The main deployment mechanism seems to be failing: https://github.com/DLR-FT/wasm-interpreter/actions/workflows/pages_deploy_main.yaml It seems to be failing due to some sort of branch protection rule.