feat: import example implementation

DLR-FT / wasm-interpreter

A minimal in-place WebAssembly interpreter, written in Rust, almost without use of external dependencies

https://dlr-ft.github.io/wasm-interpreter/main/

Apache License 2.0

10 stars 4 forks source link

feat: import example implementation #81

Open nerodesu017 opened 2 months ago

nerodesu017 commented 2 months ago

Pull Request Overview

This pull request adds basic support for imports.

Testing Strategy

This pull request was tested using the provided test cases.

TODO or Help Wanted

It is to be discussed if this is a way through which we could implement the imports and keep the code still executing our tests (a.k.a. not break function calling).

Formatting

[x] Ran cargo fmt
[x] Ran cargo check
[x] Ran cargo build
[x] Ran cargo doc
[ ] Ran nix fmt

Github Issue

N/A

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 92.76316% with 11 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
src/execution/mod.rs	93.49%	7 Missing and 1 partial :warning:
src/validation/mod.rs	87.50%	2 Missing and 1 partial :warning:

Files with missing lines	Coverage Δ
src/execution/interpreter_loop.rs	`93.53% <100.00%> (ø)`
src/execution/store.rs	`53.33% <ø> (ø)`
src/validation/mod.rs	`63.82% <87.50%> (+6.10%)`	:arrow_up:
src/execution/mod.rs	`91.37% <93.49%> (+0.05%)`	:arrow_up:

... and 2 files with indirect coverage changes

florianhartung commented 2 months ago

i think this is related to https://github.com/DLR-FT/wasm-interpreter/issues/27

wucke13 commented 2 months ago

Maybe it is nicer to have all functions live in the same table.