Added explicit start = 0 modifiers to parameters without default binding

DLR-SR / ThermofluidStream

The DLR Thermofluid Stream Library

BSD 3-Clause "New" or "Revised" License

65 stars 27 forks source link

Added explicit start = 0 modifiers to parameters without default binding #187

Closed casella closed 4 months ago

casella commented 5 months ago

This fixes #171.

dzimmer commented 5 months ago

Will be substituted by a PR on #171 from @tobolar. (see discussion) Thank you for suggesting a first solutions and make us think about it.

casella commented 5 months ago

Not sure #171 is good either, see comment.

dzimmer commented 4 months ago

I will not accept this PR as is but your latest suggestion of #171 with the assert statement seems good to me.
I have reopened this PR in case you want to do the changes. I can do it as well but I won't do it before Friday. Now I feel my jetlag. I fail to write English... I shall not code Modelica...

dzimmer commented 4 months ago

substituted by #201 according to discussion in #171