DOI-USGS / ISIS3

Integrated Software for Imagers and Spectrometers v3. ISIS3 is a digital image processing software package to manipulate imagery collected by current and past NASA and International planetary missions.
https://isis.astrogeology.usgs.gov
Other
197 stars 166 forks source link

The algebra application has been refactored to be callable; Makefile tests converted to gtests and removed. #5597

Closed kledmundson closed 2 weeks ago

kledmundson commented 1 month ago

Description

The algebra application has been refactored to be callable. Makefile tests have been converted to gtests utilizing the DefaultCube test fixture. Makefile tests have been removed.

Related Issue

https://github.com/DOI-USGS/ISIS3/issues/5594

How Has This Been Validated?

Results of ctest suite...

ctest -R FunctionalTestAlgebra --output-on-failure Test project /Users/kledmundson/ISISDev/algebra/Jul212024/ISIS3/build Start 1684: AlgebraCube.FunctionalTestAlgebraAdd 1/5 Test #1684: AlgebraCube.FunctionalTestAlgebraAdd ........ Passed 1.58 sec Start 1685: AlgebraCube.FunctionalTestAlgebraSubtract 2/5 Test #1685: AlgebraCube.FunctionalTestAlgebraSubtract ... Passed 1.57 sec Start 1686: AlgebraCube.FunctionalTestAlgebraMultiply 3/5 Test #1686: AlgebraCube.FunctionalTestAlgebraMultiply ... Passed 1.57 sec Start 1687: AlgebraCube.FunctionalTestAlgebraDivide 4/5 Test #1687: AlgebraCube.FunctionalTestAlgebraDivide ..... Passed 1.58 sec Start 1688: AlgebraCube.FunctionalTestAlgebraUnary 5/5 Test #1688: AlgebraCube.FunctionalTestAlgebraUnary ...... Passed 1.56 sec

100% tests passed, 0 tests failed out of 5 Total Test time (real) = 8.06 sec

Types of changes

Checklist:

Licensing

This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words:

This work is free and unencumbered software released into the public domain. In jurisdictions that recognize copyright laws, the author or authors of this software dedicate any and all copyright interest in the software to the public domain.

github-actions[bot] commented 1 month ago

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5597".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.