search

DOI-USGS / ale

Abstraction Layer for Ephemerides (ALE)
Other
13 stars 33 forks source link

Msl Focal2Pixel Fix #492

Closed acpaquette closed 2 years ago

acpaquette commented 2 years ago

Fixed value order for focal2pixel_samples vector

Kelvinrr commented 2 years ago

Tested locally and was able to csminit

jessemapel commented 2 years ago

@Kelvinrr @acpaquette This looks good, but it seems the test data needs to be updated.

codecov-commenter commented 2 years ago

Codecov Report

Merging #492 (e2266f0) into master (063d6ff) will decrease coverage by 0.00%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #492      +/-   ##
==========================================
- Coverage   18.06%   18.05%   -0.01%     
==========================================
  Files          50       50              
  Lines        5276     5277       +1     
==========================================
  Hits          953      953              
- Misses       4323     4324       +1
Impacted Files Coverage Δ
ale/drivers/msl_drivers.py 0.00% <0.00%> (ø)
src/Orientations.cpp 89.07% <0.00%> (-0.76%) :arrow_down:
ale/util.py 0.00% <0.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more