Closed padilla410 closed 2 years ago
This PR closes https://github.com/USGS-R/lake-temperature-model-prep/issues/320.
WOW! Going to review this morning. So exciting 🎉
Every time I try to build locally, something happens. I tried to pull down and do a local build of your branch, but mine shows a different hash for 7a_temp_coop_munge/src/data_parsers/parse_mndnr_files.R and starts to rebuild more than it should. Let's just trust what you have!
I think you see the different hash because Long 29016100
and temp_DO_PCA
have their parsers in the parse_mndnr_files.R
file (they're from MNDNR so it seemed reasonable to drop them in there. I assume you're seeing a lot of files rebuild because the pipeline is rebuilding all the MNDNR files (everything that depends on parse_mndnr_files()
. So, in retrospect, maybe I should have dropped these two additional MNDNR parsers into their own file.
Overview
This PR includes parsers for the following datasets from #320:
Long 29016100
temp_DO_PCA
NorfolkReservoir_hwy62_AR_monthlyTempDO_2016_2020.xlsx
NorfolkReservoir_dam_AR_monthlyTempDO_2016_2020.xlsx
MASTER_mnlakedata_ historicalfiles_manualentry_ template.xlsx
was going to be in this PR but the DOW numbers are highly problematic and would need manual verification.I also cleaned up
lake-temperature-model-prep > 6_temp_coop_fetch > data_queue
by moving the datasets we are going to skip into~ > data_archive > not_pursuing
This PR closes #320. The other three files listed as parser candidates were tackled in #337.
Results from scmake("8_viz")
A numbers snapshot from 8_viz/out/lakes_summary_fig.html (same as #333 and #337):
Verification that the expected data is in the final data