search

DReichLab / EIG

Eigen tools by Nick Patterson and Alkes Price lab
Other
180 stars 60 forks source link

Fix build for OSX-arm64 #97

Open tschuelia opened 1 year ago

tschuelia commented 1 year ago

With these fixes Eigensoft can also bei installed on OSX-arm64.

Two issues prevent this so far:

  1. The finite function is obsolete and should be replaced with isfinite (see https://linux.die.net/man/3/finite). It seems that this was done in many cases, but missed in one.
  2. The compiler option -p seems to be invalid for the apple clang compiler, as far as I understand this flag is also not required for other platforms for the normal execution mode of e.g. smartpca (as it is a profiling flag?).
alexreg commented 6 months ago

Thank you very much! I came here with the same problem, and this does the job nicely.

nsander57 commented 6 months ago

I also was looking for this fix. Thank you so much!