fix: old upper bound dep for `mean_average_precision`

DS4SD / docling-ibm-models

MIT License

45 stars 10 forks source link

Closed hadim closed 1 week ago

hadim commented 1 week ago

Checklist:

[x] Commit Message Formatting: Commit titles and messages follow guidelines in the conventional commits.
[ ] Documentation has been updated, if necessary.
[ ] Examples have been added, if necessary.
[ ] Tests have been added, if necessary.

hadim commented 1 week ago

It prevents pip check working correctly, which is problematic for the downstream conda forge package at https://github.com/conda-forge/docling-ibm-models-feedstock

hadim commented 1 week ago

ping @dolfim-ibm

dolfim-ibm commented 1 week ago

I was just checking. Honestly, I think we should simply remove this dependency, since it is not used.

maxmnemonic commented 1 week ago

@hadim thanks for pointing us to this, indeed dependency is not used in the current code, so we will remove it, with this PR: https://github.com/DS4SD/docling-ibm-models/pull/53

maxmnemonic commented 1 week ago

@hadim we deleted dependency, closing this PR