Closed alexchen2 closed 5 months ago
Primary reviewer is @cenesdeveloper
Enes has a lot on his plate this week and will not be able to review the PR, so I'm changing the primary reviewer to @racheldennis
There are a lot of merge conflicts to be resolved
It's probably related to some changes I made to condense repetitive render_template()
current_user arguments into a single dictionary; as a result, future endpoints added to main.py only require you to instantiate and unpack a dict, as opposed to adding a slew of arguments inside every render_template()
where forgetting one arg will cause the server to throw a hissy fit. I'll just quickly deal with the conflicts, it shouldn't be a big deal I think
Please don't merge this yet, it seems like some genius recently decided to commit a bunch of old files (at least from 1-2 months ago) to the main repo and now everything appears to be broken. Will look into if there's an quick and easy fix for this
Will merge this for now. I'll create a separate PR with server bug fixes as well as fixing the entire login system to actually function properly, since there are a couple of concerning issues with this like:
Changes Made:
z-index
doesn't seem to work), so odds are, the page may be edited in the future to remove these circles all together on mobile-sized screens.~ (fixed in update below)authPage.css
. Unique attributes for each of the two pages still remain within the separate CSS files,login.css
andregister.css
.main.py
endpoint to properly render data from the database (previously, hardcoded placeholder data was being shown and variables referencing the DB were incorrect).Disclaimers/Things to Note:
dashboard.css
anddashboard.html
files significantly (#107, #114). Overall though, only minimal changes should be needed to tweak the design and make it match the other pages (border/shadow/color/font edits).Further Additions (03-09-2024):
main.py
so that when callingrender_template()
, all common logged-in user info is passed as a single unpacked dictionaryreturnLoggedInData
(this helps with conciseness, while reducing the chance of bugs arising from forgetting to pass jinja variables).registerNew.css
toregister.css
and moved the old CSS file to a separate folder.user_profile.html
...? (not sure if sessionStorage.includes() is a valid method for sessionStorage)dashboard.css
(they were also messing with the profile menu fonts as well).