DSH105 / EchoPet

Adds pets to your Minecraft Server!
http://dev.bukkit.org/bukkit-plugins/echopet/
GNU General Public License v3.0
48 stars 116 forks source link

[1.7.10] [EchoPets 3.0] Current Issues. #360

Open mibby opened 10 years ago

mibby commented 10 years ago

@DSH105 Compiled https://github.com/DSH105/EchoPet/tree/3.x after tackling missing dependency compilation errors posted https://github.com/DSH105/EchoPet/commit/a4cb2f6dd8bc2ce9c90c110b3442a57dac2e301e#commitcomment-6991168 with @eueln's posted fix for this error that still persists https://github.com/DSH105/EchoPet/issues/359, only to run into more issues stopping the pursuit to test and use EchoPets for 1.7.10. :P

[03:21:00] [Server thread/ERROR]: Could not pass event ChunkUnloadEvent to EchoPet v3.0.0-SNAPSHOT-b
org.bukkit.event.EventException
    at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:299) ~[spigot.jar:git-Spigot-1551]
    at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:62) ~[spigot.jar:git-Spigot-1551]
    at org.bukkit.plugin.SimplePluginManager.fireEvent(SimplePluginManager.java:502) [spigot.jar:git-Spigot-1551]
    at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:487) [spigot.jar:git-Spigot-1551]
    at net.minecraft.server.v1_7_R4.ChunkProviderServer.unloadChunks(ChunkProviderServer.java:342) [spigot.jar:git-Spigot-1551]
    at net.minecraft.server.v1_7_R4.WorldServer.doTick(WorldServer.java:196) [spigot.jar:git-Spigot-1551]
    at net.minecraft.server.v1_7_R4.MinecraftServer.v(MinecraftServer.java:687) [spigot.jar:git-Spigot-1551]
    at net.minecraft.server.v1_7_R4.DedicatedServer.v(DedicatedServer.java:289) [spigot.jar:git-Spigot-1551]
    at net.minecraft.server.v1_7_R4.MinecraftServer.u(MinecraftServer.java:584) [spigot.jar:git-Spigot-1551]
    at net.minecraft.server.v1_7_R4.MinecraftServer.run(MinecraftServer.java:490) [spigot.jar:git-Spigot-1551]
    at net.minecraft.server.v1_7_R4.ThreadServerApplication.run(SourceFile:628) [spigot.jar:git-Spigot-1551]
Caused by: java.lang.RuntimeException: Failed to create/find a converter for: org.bukkit.craftbukkit.v1_7_R4.entity.CraftItem
    at com.captainbern.minecraft.conversion.BukkitUnwrapper.unwrap(BukkitUnwrapper.java:38) ~[?:?]
    at com.dsh105.echopetv3.listeners.ChunkListener.onChunkUnload(ChunkListener.java:35) ~[?:?]
    at sun.reflect.GeneratedMethodAccessor2.invoke(Unknown Source) ~[?:?]
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_20-ea]
    at java.lang.reflect.Method.invoke(Unknown Source) ~[?:1.8.0_20-ea]
    at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:296) ~[spigot.jar:git-Spigot-1551]
    ... 10 more
Caused by: java.lang.RuntimeException: Failed to unwrap: CraftItem(org.bukkit.craftbukkit.v1_7_R4.entity.CraftItem)
    at com.captainbern.minecraft.conversion.BukkitUnwrapper.unwrap(BukkitUnwrapper.java:62) ~[?:?]
    at com.captainbern.minecraft.conversion.BukkitUnwrapper.unwrap(BukkitUnwrapper.java:35) ~[?:?]
    at com.dsh105.echopetv3.listeners.ChunkListener.onChunkUnload(ChunkListener.java:35) ~[?:?]
    at sun.reflect.GeneratedMethodAccessor2.invoke(Unknown Source) ~[?:?]
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_20-ea]
    at java.lang.reflect.Method.invoke(Unknown Source) ~[?:1.8.0_20-ea]
    at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:296) ~[spigot.jar:git-Spigot-1551]
    ... 10 more

I believe same error posted multiple times. http://paste.ubuntu.com/7792839/

mibby commented 10 years ago

Slightly different error.

[03:32:29] [Server thread/ERROR]: Could not pass event ChunkUnloadEvent to EchoPet v3.0.0-SNAPSHOT-b
org.bukkit.event.EventException
    at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:299) ~[spigot.jar:git-Spigot-1551]
    at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:62) ~[spigot.jar:git-Spigot-1551]
    at org.bukkit.plugin.SimplePluginManager.fireEvent(SimplePluginManager.java:502) [spigot.jar:git-Spigot-1551]
    at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:487) [spigot.jar:git-Spigot-1551]
    at net.minecraft.server.v1_7_R4.ChunkProviderServer.unloadChunks(ChunkProviderServer.java:342) [spigot.jar:git-Spigot-1551]
    at net.minecraft.server.v1_7_R4.WorldServer.doTick(WorldServer.java:196) [spigot.jar:git-Spigot-1551]
    at net.minecraft.server.v1_7_R4.MinecraftServer.v(MinecraftServer.java:687) [spigot.jar:git-Spigot-1551]
    at net.minecraft.server.v1_7_R4.DedicatedServer.v(DedicatedServer.java:289) [spigot.jar:git-Spigot-1551]
    at net.minecraft.server.v1_7_R4.MinecraftServer.u(MinecraftServer.java:584) [spigot.jar:git-Spigot-1551]
    at net.minecraft.server.v1_7_R4.MinecraftServer.run(MinecraftServer.java:490) [spigot.jar:git-Spigot-1551]
    at net.minecraft.server.v1_7_R4.ThreadServerApplication.run(SourceFile:628) [spigot.jar:git-Spigot-1551]
Caused by: java.lang.RuntimeException: Failed to create/find a converter for: org.bukkit.craftbukkit.v1_7_R4.entity.CraftMinecartChest
    at com.captainbern.minecraft.conversion.BukkitUnwrapper.unwrap(BukkitUnwrapper.java:38) ~[?:?]
    at com.dsh105.echopetv3.listeners.ChunkListener.onChunkUnload(ChunkListener.java:35) ~[?:?]
    at sun.reflect.GeneratedMethodAccessor2.invoke(Unknown Source) ~[?:?]
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_20-ea]
    at java.lang.reflect.Method.invoke(Unknown Source) ~[?:1.8.0_20-ea]
    at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:296) ~[spigot.jar:git-Spigot-1551]
    ... 10 more
Caused by: java.lang.RuntimeException: Failed to unwrap: CraftMinecartChest{inventory=org.bukkit.craftbukkit.v1_7_R4.inventory.CraftInventory@12d}(org.bukkit.craftbukkit.v1_7_R4.entity.CraftMinecartChest)
    at com.captainbern.minecraft.conversion.BukkitUnwrapper.unwrap(BukkitUnwrapper.java:62) ~[?:?]
    at com.captainbern.minecraft.conversion.BukkitUnwrapper.unwrap(BukkitUnwrapper.java:35) ~[?:?]
    at com.dsh105.echopetv3.listeners.ChunkListener.onChunkUnload(ChunkListener.java:35) ~[?:?]
    at sun.reflect.GeneratedMethodAccessor2.invoke(Unknown Source) ~[?:?]
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_20-ea]
    at java.lang.reflect.Method.invoke(Unknown Source) ~[?:1.8.0_20-ea]
    at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:296) ~[spigot.jar:git-Spigot-1551]
    ... 10 more
CaptainBern commented 10 years ago

Checking if the entity (https://github.com/DSH105/EchoPet/blob/3.x/modules/EchoPet/src/main/java/com/dsh105/echopetv3/listeners/ChunkListener.java ) is an instance of EntityLiving would/could fix this.

mibby commented 10 years ago

Also some personal observations about v3.0 so far.

# Remindsplayerstohoverovercommandstoseemoreinformation
### V3.0 config ###
slots:
  slot-1:
    name: Bat
    material: MONSTER_EGG
    materialData: 65
    amount: 1
### V3.0 config ###
slot-1:
  command: pet bat
  permission: echopet.pet.type.bat
  changeNameColours: true
  performAsConsole: false
### V2.0 config ###
    slot-1:
      command: pet bat
      petType: BAT
      materialId: 383
      materialData: 65
      name: Bat Pet
      lore: ''
### V2.0 config ###
  bat:
    enable: true
    tagVisible: true
    defaultName: Pet Bat
    interactMenu: true
    startFollowDistance: 12
    stopFollowDistance: 4
    teleportDistance: 150
    attack:
      canDamagePlayers: false
      lockRange: 10
      ticksBetweenAttacks: 20
      damage: 3.0
      loseHealth: false
      health: 6
    rideSpeed: 0.2
    jumpHeight: 0.6
    canFly: true
    allow:
      mounts: false
      riders: true

Config comparison v3.0 - http://paste.ubuntu.com/7792896/ v2.0 - http://paste.ubuntu.com/7792963/

Sigh. :P And I haven't even tested pet functions yet, whether they despawn properly, chunk errors, memory leaks, riding, hat, naming, pet riding another pet while disguised as a mob riding those pets, if all permissions work, etc. (Can't even spawn in pets yet.)

Mibby is sad and only wanted 1.7.10 pets. :(

DSH105 commented 10 years ago

crikey

DSH105 commented 10 years ago

https://github.com/DSH105/EchoPet/commit/b32c2d9dfee793867865f7d1126af0c8babe7adf

DSH105 commented 10 years ago

https://github.com/DSH105/EchoPet/commit/82bf7405aab8797eb812acc109f0de88338d943e

DSH105 commented 10 years ago

https://github.com/DSH105/MenuAPI/commit/616bc5bec79cf1c0c5f5d4dd914ac9583e45df47

mibby commented 10 years ago

@DSH105 Recompiled EchoPets 3.0 as of this commit. https://github.com/DSH105/EchoPet/commit/7130c782697678ba4c55761a0a370348eb88d396

Current issues as far as my testing has gone. Missing config values and broken configs have been fixed, yay!

Can't really test anything else since I'm still unable to spawn pets in. :(

Edit: Got frustrated with being unable to enter another help page so I tried '/pet help [3]'. Errors ensued! :P

[01:29:02] [Server thread/ERROR]: null
org.bukkit.command.CommandException: Unhandled exception executing 'pet help <3>' in com.dsh105.command.registration.DynamicPluginCommand(pet)
    at org.bukkit.command.SimpleCommandMap.dispatch(SimpleCommandMap.java:188) ~[spigot.jar:git-Spigot-1552]
    at org.bukkit.craftbukkit.v1_7_R4.CraftServer.dispatchCommand(CraftServer.java:767) ~[spigot.jar:git-Spigot-1552]
    at net.minecraft.server.v1_7_R4.PlayerConnection.handleCommand(PlayerConnection.java:1016) [spigot.jar:git-Spigot-1552]
    at net.minecraft.server.v1_7_R4.PlayerConnection.a(PlayerConnection.java:846) [spigot.jar:git-Spigot-1552]
    at net.minecraft.server.v1_7_R4.PacketPlayInChat.a(PacketPlayInChat.java:28) [spigot.jar:git-Spigot-1552]
    at net.minecraft.server.v1_7_R4.PacketPlayInChat.handle(PacketPlayInChat.java:65) [spigot.jar:git-Spigot-1552]
    at net.minecraft.server.v1_7_R4.NetworkManager.a(NetworkManager.java:184) [spigot.jar:git-Spigot-1552]
    at net.minecraft.server.v1_7_R4.ServerConnection.c(ServerConnection.java:81) [spigot.jar:git-Spigot-1552]
    at net.minecraft.server.v1_7_R4.MinecraftServer.v(MinecraftServer.java:731) [spigot.jar:git-Spigot-1552]
    at net.minecraft.server.v1_7_R4.DedicatedServer.v(DedicatedServer.java:289) [spigot.jar:git-Spigot-1552]
    at net.minecraft.server.v1_7_R4.MinecraftServer.u(MinecraftServer.java:584) [spigot.jar:git-Spigot-1552]
    at net.minecraft.server.v1_7_R4.MinecraftServer.run(MinecraftServer.java:490) [spigot.jar:git-Spigot-1552]
    at net.minecraft.server.v1_7_R4.ThreadServerApplication.run(SourceFile:628) [spigot.jar:git-Spigot-1552]
Caused by: com.dsh105.command.exception.CommandInvalidException: Invalid pattern syntax for command (pet <r:([^\s]+)(:[^\s]+)?(;.+)?,n:<type>:[data];[name...]>): ([^\s
    at com.dsh105.command.VariableMatcher.buildVariableSyntax(VariableMatcher.java:67) ~[?:?]
    at com.dsh105.command.VariableMatcher.matches(VariableMatcher.java:92) ~[?:?]
    at com.dsh105.command.CommandManager.getCommandMethod(CommandManager.java:577) ~[?:?]
    at com.dsh105.command.CommandManager.getCommandMethod(CommandManager.java:553) ~[?:?]
    at com.dsh105.command.CommandManager.onCommand(CommandManager.java:635) ~[?:?]
    at com.dsh105.command.CommandManager.onCommand(CommandManager.java:624) ~[?:?]
    at com.dsh105.command.registration.DynamicPluginCommand.execute(DynamicPluginCommand.java:45) ~[?:?]
    at org.bukkit.command.SimpleCommandMap.dispatch(SimpleCommandMap.java:181) ~[spigot.jar:git-Spigot-1552]
    ... 12 more
Caused by: java.util.regex.PatternSyntaxException: Unclosed character class near index 4
([^\s
    ^
    at java.util.regex.Pattern.error(Unknown Source) ~[?:1.8.0_20-ea]
    at java.util.regex.Pattern.clazz(Unknown Source) ~[?:1.8.0_20-ea]
    at java.util.regex.Pattern.sequence(Unknown Source) ~[?:1.8.0_20-ea]
    at java.util.regex.Pattern.expr(Unknown Source) ~[?:1.8.0_20-ea]
    at java.util.regex.Pattern.group0(Unknown Source) ~[?:1.8.0_20-ea]
    at java.util.regex.Pattern.sequence(Unknown Source) ~[?:1.8.0_20-ea]
    at java.util.regex.Pattern.expr(Unknown Source) ~[?:1.8.0_20-ea]
    at java.util.regex.Pattern.compile(Unknown Source) ~[?:1.8.0_20-ea]
    at java.util.regex.Pattern.<init>(Unknown Source) ~[?:1.8.0_20-ea]
    at java.util.regex.Pattern.compile(Unknown Source) ~[?:1.8.0_20-ea]
    at com.dsh105.command.VariableMatcher.buildVariableSyntax(VariableMatcher.java:65) ~[?:?]
    at com.dsh105.command.VariableMatcher.matches(VariableMatcher.java:92) ~[?:?]
    at com.dsh105.command.CommandManager.getCommandMethod(CommandManager.java:577) ~[?:?]
    at com.dsh105.command.CommandManager.getCommandMethod(CommandManager.java:553) ~[?:?]
    at com.dsh105.command.CommandManager.onCommand(CommandManager.java:635) ~[?:?]
    at com.dsh105.command.CommandManager.onCommand(CommandManager.java:624) ~[?:?]
    at com.dsh105.command.registration.DynamicPluginCommand.execute(DynamicPluginCommand.java:45) ~[?:?]
    at org.bukkit.command.SimpleCommandMap.dispatch(SimpleCommandMap.java:181) ~[spigot.jar:git-Spigot-1552]
    ... 12 more

Edit 2: Restarted my test server for the lols. Error occurred on startup.

[01:54:57] [Server thread/INFO]: [EchoPet] Enabling EchoPet v3.0.0-SNAPSHOT-b
[01:54:57] [Server thread/ERROR]: Error occurred while enabling EchoPet v3.0.0-SNAPSHOT-b (Is it up to date?)
java.lang.NullPointerException
    at com.dsh105.menuapi.api.Icon.<init>(Icon.java:98) ~[?:?]
    at com.dsh105.menuapi.api.CommandIcon.<init>(CommandIcon.java:90) ~[?:?]
    at com.dsh105.menuapi.api.Layout.loadFromFile(Layout.java:203) ~[?:?]
    at com.dsh105.echopetv3.api.inventory.PetSelector.getLayout(PetSelector.java:59) ~[?:?]
    at com.dsh105.echopetv3.api.config.MenuSettings.setDefaults(MenuSettings.java:40) ~[?:?]
    at com.dsh105.commodus.config.Options.<init>(Options.java:34) ~[?:?]
    at com.dsh105.echopetv3.api.config.MenuSettings.<init>(MenuSettings.java:30) ~[?:?]
    at com.dsh105.echopetv3.EchoPetPlugin.loadConfiguration(EchoPetPlugin.java:160) ~[?:?]
    at com.dsh105.echopetv3.EchoPetPlugin.onEnable(EchoPetPlugin.java:106) ~[?:?]
    at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:316) ~[spigot.jar:git-Spigot-1552]
    at org.bukkit.plugin.java.JavaPluginLoader.enablePlugin(JavaPluginLoader.java:329) [spigot.jar:git-Spigot-1552]
    at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManager.java:405) [spigot.jar:git-Spigot-1552]
    at org.bukkit.craftbukkit.v1_7_R4.CraftServer.loadPlugin(CraftServer.java:476) [spigot.jar:git-Spigot-1552]
    at org.bukkit.craftbukkit.v1_7_R4.CraftServer.enablePlugins(CraftServer.java:394) [spigot.jar:git-Spigot-1552]
    at net.minecraft.server.v1_7_R4.MinecraftServer.n(MinecraftServer.java:360) [spigot.jar:git-Spigot-1552]
    at net.minecraft.server.v1_7_R4.MinecraftServer.g(MinecraftServer.java:334) [spigot.jar:git-Spigot-1552]
    at net.minecraft.server.v1_7_R4.MinecraftServer.a(MinecraftServer.java:290) [spigot.jar:git-Spigot-1552]
    at net.minecraft.server.v1_7_R4.DedicatedServer.init(DedicatedServer.java:210) [spigot.jar:git-Spigot-1552]
    at net.minecraft.server.v1_7_R4.MinecraftServer.run(MinecraftServer.java:458) [spigot.jar:git-Spigot-1552]
    at net.minecraft.server.v1_7_R4.ThreadServerApplication.run(SourceFile:628) [spigot.jar:git-Spigot-1552]
stuntguy3000 commented 10 years ago

@mibby The regex issues should be fixed

mibby commented 10 years ago

@stuntguy3000 Yeah. DSH105 informed me a few of these issues have already been fixed. Seems to be an issue with the CI jenkins server, pom pulled the wrong dependency even though I manually compiled all the sources and clean installed. :s Will recompile all dependencies and 3.x manually in the afternoon to re-test everything, with a clean maven index.

mibby commented 10 years ago

All issues above still present. Compiled all dependency sources manually on a clean maven index, still experiencing all/most issues. Such as not being able to spawn in pets, the regex is messy in help pages, can't access past help page 1, etc.

Edit: And restarting the server after a functional compilation/first load, it errors when trying to load.

[03:07:00] [Server thread/ERROR]: Error occurred while enabling EchoPet v3.0.0-SNAPSHOT-b (Is it up to date?)
java.lang.NullPointerException
    at com.dsh105.menuapi.api.Icon.<init>(Icon.java:98) ~[?:?]
    at com.dsh105.menuapi.api.CommandIcon.<init>(CommandIcon.java:90) ~[?:?]
    at com.dsh105.menuapi.api.Layout.loadFromFile(Layout.java:203) ~[?:?]
    at com.dsh105.echopetv3.api.inventory.PetSelector.getLayout(PetSelector.java:59) ~[?:?]
    at com.dsh105.echopetv3.api.config.MenuSettings.setDefaults(MenuSettings.java:40) ~[?:?]
    at com.dsh105.commodus.config.Options.<init>(Options.java:34) ~[?:?]
    at com.dsh105.echopetv3.api.config.MenuSettings.<init>(MenuSettings.java:30) ~[?:?]
    at com.dsh105.echopetv3.EchoPetPlugin.loadConfiguration(EchoPetPlugin.java:161) ~[?:?]
    at com.dsh105.echopetv3.EchoPetPlugin.onEnable(EchoPetPlugin.java:107) ~[?:?]
    at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:316) ~[spigot.jar:git-Spigot-1553]
    at org.bukkit.plugin.java.JavaPluginLoader.enablePlugin(JavaPluginLoader.java:329) [spigot.jar:git-Spigot-1553]
    at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManager.java:405) [spigot.jar:git-Spigot-1553]
    at org.bukkit.craftbukkit.v1_7_R4.CraftServer.loadPlugin(CraftServer.java:476) [spigot.jar:git-Spigot-1553]
    at org.bukkit.craftbukkit.v1_7_R4.CraftServer.enablePlugins(CraftServer.java:394) [spigot.jar:git-Spigot-1553]
    at net.minecraft.server.v1_7_R4.MinecraftServer.n(MinecraftServer.java:360) [spigot.jar:git-Spigot-1553]
    at net.minecraft.server.v1_7_R4.MinecraftServer.g(MinecraftServer.java:334) [spigot.jar:git-Spigot-1553]
    at net.minecraft.server.v1_7_R4.MinecraftServer.a(MinecraftServer.java:290) [spigot.jar:git-Spigot-1553]
    at net.minecraft.server.v1_7_R4.DedicatedServer.init(DedicatedServer.java:210) [spigot.jar:git-Spigot-1553]
    at net.minecraft.server.v1_7_R4.MinecraftServer.run(MinecraftServer.java:458) [spigot.jar:git-Spigot-1553]
    at net.minecraft.server.v1_7_R4.ThreadServerApplication.run(SourceFile:628) [spigot.jar:git-Spigot-1553]