DShirk / Mod-97-Check-Digits

HMDA ULI Mod 97 Check Digits Generator and Validator
0 stars 0 forks source link

Check digit generator invalid in some cases where check digits should have ended in 8 #1

Closed DShirk closed 6 years ago

DShirk commented 6 years ago

C. Perry identified the following concerns on 12-18-2017.

When I went to manually generate some ULI’s for loans with lender’s LEI, I used our in house validator that uses the logic that the CFPB posted. I simultaneously also used the validator at MortgageBanking.Law https://www.mortgagebanking.law/single-post/2017/05/28/ULI-Check-Digit-Calculator to ensure that I got the same ULI results through both ULI generators as a way to double check my work.

About 90% of the time both created the same check digit # but about 10% of the time I was not getting the same check digits, so obviously one of the generators had to be incorrect. When I took the MortgageBanking.Law generated ULI and plugged that # into its validator I was getting a “INVALID” result meaning the ULI was invalid. I also received a “false” result when I plugged its ULI # into our validator. Conversely, when I entered the ULI generated from our logic (CFPB) into both our validator and the MortgageBanking.Law validator I received a “True” or “Valid” result which means our ULI is correct.

The check digits that were valid in our generator but did not yield the same results in the MortgageBanking.Law validator all ended in 08,28,38,58 or 68. For some reason both were able to generate a 98.

DShirk commented 6 years ago

Resolved with dshirk-patch-1