search

DUNE-DAQ / drunc

Dune RUN Control (DRUNC) is the run control for the DUNE experiment
1 stars 1 forks source link

This line is too simplistic to cast a str to bool #92

Closed plasorak closed 2 months ago

plasorak commented 5 months ago

We need to explicitely check for false, 0, no, not, whatever, and throw if it's not evaluated to true or false.

https://github.com/DUNE-DAQ/drunc/blob/c393c372cd3033442bd872ea6a5ce49afba413f8/src/drunc/controller/interface/shell_utils.py#L200C45-L200C50

plasorak commented 2 months ago

Not needed anymore