search

DWorkS / VolleyPlus

🏐 Volley library : make everything faster . Its an improvements for Volley by Google for Android https://android.googlesource.com/platform/frameworks/volley
https://github.com/DWorkS/VolleyPlus
984 stars 274 forks source link

Add NegativeArraySizeException in DiskBasedCache #78

Closed 1jpgodara closed 6 years ago

1jpgodara commented 6 years ago
1hakr commented 6 years ago

I believe this has been fixed with this commit https://github.com/DWorkS/VolleyPlus/commit/ef9abc37f666863b84c6dc0fea93ee1170ac7b3c Let me know if this doesn't fix this.

Closing it for now.

1jpgodara commented 6 years ago

https://github.com/DWorkS/VolleyPlus/commit/ef9abc37f666863b84c6dc0fea93ee1170ac7b3c#diff-c7b45ce0287631a420f5f40a21497755R122 This is the fix, right?

1jpgodara commented 6 years ago

What if parallelism will happen at this time or after this? What is the harm in adding one more exception in the catch block? at least crash won't happen for users. In my code still, I am facing the same crash.

1hakr commented 6 years ago

Oh okay. You are using VolleyPlus as another module and testing and not using the through dependency, right?

If you are still getting an error then do update the PR.