search

DaDerpDuck / Seamless-Loading-Screen-Forge

Forge port. Takes a screenshot of the game when you leave a world or server, and displays it when you rejoin it
https://www.curseforge.com/minecraft/mc-mods/seamless-loading-screen-forge
MIT License
3 stars 0 forks source link

optifine "Show FPS" is visible in top left #2

Closed cpm9 closed 3 years ago

cpm9 commented 3 years ago

the optifine "Show FPS" option is visible in the top left while joining server, either it gets captured in the screenshot or is running overtop the seamless loading screen for some reason

DaDerpDuck commented 3 years ago

So Optifine's FPS gui is drawn right after the ingame guis are rendered (hotbar, boss health, crosshair, etc.) There are two cases where ingame guis are rendered, and that is whether hideGUI is not enabled (F1) or if a screen is being displayed. Seamless Loading Screen works by displaying a new screen and, immediately when rendered, takes a screenshot of what is on the screen - therefore causing ingame guis being drawn. I solved the problem of vanilla ingame guis being displayed since Forge luckily has a cancelable event for them. Optifine, however, doesn't use the event, leading to the gui being captured in the screenshot. This is a little bit of an Optifine issue so I'd suggest opening an issue there too, but I can work around it by hooking into their classes. Thanks for the report though! Their lagometer also turns out to have the same problem too, so that's two issues and one stone lol

cpm9 commented 3 years ago

that was fast haha