Open Minenash opened 1 year ago
Hey Minenash, I think that's a great idea.
I've been out of Minecraft modding due to training, but I graduated just a few days ago so the timing's actually perfect. My code mostly matches with your original Fabric mod, but I did take a different approach when it came to finding when to take a screenshot. Instead of injecting into the disconnect or close window button, I found a method in Minecraft that clears the level and opted to take the screenshot in that area, providing (in theory) a consistent way of taking screenshots when leaving for any reason.
Let me know if there's anything I can do to help.
Interesting, we'll definitely look at that (and go through the commits to see if there would be any bugs-fixes(mainly forge related)/features that are in your repo.
We recently changed our method too. It still injects in the same area, but instead of trying to force the render in a weird way, we let it naturally let it render the world before disconnecting. But yeah, if your method works on fabric as well that does sound like a simpler system than mixing into the disconnect button, wherever the window close thing is, and when it receives a server-ordered disconnect.
Hey Tim, long time no talk!
After a couple years of inactivity, 2 new maintainers have taken over the development of the main project. Besides updating to new versions, fixing the fundamental problems of the mod, and moving it to architectury to allow for fabric and forge releases with the same code base, they have also started to add more features to the mod including:
After looking at the commit history, it seems active development of the forge port stopped a couple years ago and is mainly in "update-only" mode, with the 1.20 version lacking. Do you think it might be worth combining audiences in the near future?