DaDerpDuck / Seamless-Loading-Screen-Forge

Forge port. Takes a screenshot of the game when you leave a world or server, and displays it when you rejoin it
https://www.curseforge.com/minecraft/mc-mods/seamless-loading-screen-forge
MIT License
3 stars 0 forks source link

Performance bug #3

Closed Rosentti closed 3 years ago

Rosentti commented 3 years ago

With this mod, and only this mod enabled, I get spikes in alt+f3 mode, and when walking. This seems to happen roughly every 1 second, and is in sync with disk access. Edit: The file it is trying to open is ./saves/New World (2)/icon.png Edit 2: It is the icon auto-update feature. Maybe it should run async, or after exiting the game?

image

DaDerpDuck commented 3 years ago

You are right, it is coming as an effect of the icon auto-update feature. Currently, I'm using a mixin to tell Minecraft that an icon of the world hasn't been set, forcing it to take make a new icon once in a while. I'll see if I could get it to be saved async instead

DaDerpDuck commented 3 years ago

That wasn't trivial so I'm just gonna have it save on exit instead