DaedalusGame / BetterWithAddons

Companion mod for BetterWithMods, aiming to bring back ye olde addons. Also has some extra content.
MIT License
16 stars 5 forks source link

Can't remove a spindle recipe by CraftTweaker #89

Closed Fireztonez closed 6 years ago

Fireztonez commented 6 years ago

Hello, I try to remove the Hemp Cloth spindle recipe, for add a Rope recipe using Hemp Fibers.

My script I made for that is : mods.betterwithaddons.Spindle.remove(<betterwithmods:material:3>); mods.betterwithaddons.Spindle.add([<betterwithmods:rope>],<betterwithmods:material:3>*9,false);

On jei, when I look Spindle recipes using Hemp Fibers, this is little strange, I see both recipe, bot the one for the Hemp Cloth is show like using only one Hemp Fiber, but it using 9 for made a Cloth... 2018-03-31 15_21_52-minecraft 1 12 2

Minecraft: 1.12.2 Better With Addons : 0.34 Better With Mods : 2.0.32 Forge : 14.23.2.2640 CraftTweaker: 4.1.6

DaedalusGame commented 6 years ago

oh that's nice. The mirror-side of the issue. This one shows 1 item but requires 8.

Fireztonez commented 6 years ago

Yes that is strange too!!

Fireztonez commented 6 years ago

I see you close the issues, so I guess you have to find the problem!

DaedalusGame commented 6 years ago

update is delayed by a few hours because i wiped the config and i will only update if everything works correctly. edit: my config mistakenly migrated into the BWM config, that should be fixed and will be ready soon

Fireztonez commented 6 years ago

Problem still not fix, the recipe for the Hemp Cloth is still there, the only thing have change, now is show in JEI like needed 9 Hemp Fiber.

Can you look to fix the real problem? My big consern is not fact of showing wrong in JEI, but the fact of the delete recipe doesn't delete the recipe!!

hemp_cloth

hemp_cloth-not-remove

DaedalusGame commented 6 years ago

a classic, retrieving the recipe to be removed before the recipe even exists

Fireztonez commented 6 years ago

Ok, thank's, I just see the link to the source code, so I see the hotfix!

Thank's

Fireztonez commented 6 years ago

Look like the problem is still present.... JEI still show both recipes. Can you look if I do everithing right in the script on the first post? If ios not an error from me, I think something wrong on the mod again :-/

Fireztonez

DaedalusGame commented 6 years ago

mods.betterwithaddons.Spindle.remove(<betterwithmods:material:3>*9);

Fireztonez commented 6 years ago

:o thank's!