DaemonEngine / Daemon

The Dæmon game engine. With some bits of ioq3 and XreaL.
https://unvanquished.net
BSD 3-Clause "New" or "Revised" License
295 stars 60 forks source link

partial void effect on station15 tree model #119

Open illwieckz opened 6 years ago

illwieckz commented 6 years ago

See that weird void effect at the tip of the conifer branch:

incorrect

It must look like this:

correct

Note that the bug seems to occur on the collision with the plant leaf model. For information, there is also an alphagen brush in source map at this place:

netradiant

This bug looks somewhat related to that bug noticed in wolf:et map (at least for the tree): https://github.com/Unvanquished/Unvanquished/issues/799#issuecomment-253367127

illwieckz commented 6 years ago

@gimhael the somwhat fix for #118 also somewhat fixes this (the texture is right but lighting is wrong):

incorrect

somewhat correct

It also somewhat fixes Unvanquished/Unvanquished#799 bug at least for the tree part:

incorrect

somewhat correct

But that variant of the bug is still remaining:

incorrect

It was noticed in Unvanquished/Unvanquished#799 (see comment) that the wolf:et bug was introduced in 6cb4dcc but the source tree was buildable starting with commit 97cbb46 (those are translated commit ids in Daemon repository after engine split, see the other thread for commits ids on Unvanquished repository).

illwieckz commented 6 years ago

For testing purpose a snapshot of for-0.51.0 assets (including station15 map) can be fetched this way:

wget -O- http://gg.illwieckz.net/dl/unvanquished/dev/UnvanquishedAssets.get | xargs wget
illwieckz commented 6 years ago

For testing purpose one can load wolf:et's railgun map this way:

pimi.sh etmain
mkdir -p ~/.local/share/unvanquished/pkg/etmain
mkdir -p ~/.local/share/unvanquished/game/layouts/railgun
ln -s ~/.etlegacy/etmain/pak0.pk3 ~/.local/share/unvanquished/pkg/etmain/pak0_0.dpk
ln -s ~/.etlegacy/etmain/pak1.pk3 ~/.local/share/unvanquished/pkg/etmain/pak1_0.dpk
ln -s ~/.etlegacy/etmain/pak2.pk3 ~/.local/share/unvanquished/pkg/etmain/pak2_0.dpk
wget -O ~/.local/share/unvanquished/pkg/etmain/res-etmain_0.dpk http://dl.illwieckz.net/b/unvanquished/extra/foreign-maps/etmain/pkg/etmain/res-etmain_0.pk3
wget -O ~/.local/share/unvanquished/pkg/etmain/map-railgun_0.dpk http://dl.illwieckz.net/b/unvanquished/extra/foreign-maps/etmain/pkg/etmain/map-railgun_0.pk3
wget -O ~/.local/share/unvanquished/game/layouts/railgun/spawn.dat http://dl.illwieckz.net/b/unvanquished/extra/foreign-maps/etmain/game/layouts/railgun/spawn.dat
daemon -pakpath ~/.local/share/unvanquished/pkg/etmain/ +set g_neverend 1 +devmap railgun
daemon -pakpath ~/.local/share/unvanquished/pkg/etmain/ +devmap railgun spawn
illwieckz commented 5 years ago

note that the unattended side-effect "somewhat fix" previously talked about is not there anymore, bug was brought back when lighting was fixed, i.e the complete fix for the other bug left this one unmodified despite some work in progress had some effect on this.

ghost commented 2 years ago

The tree thing seems still true as of 0.52.1:

image deleted to avoid wasting people's bandwidth

illwieckz commented 2 years ago

Your screenshot doesn't depict the bug, it is worked around by r_clear being enabled, well, it is less obvious with r_clear being enabled, and the screenshot is too low resolution to notice the bug precisely, the bug only affects the tip of one branch, you'll need to zoom-in more.

Anyway the bug is still there

ghost commented 2 years ago

Then I'm failing to understand the problem.

illwieckz commented 2 years ago

This may help: https://imgsli.com/ODgwMjI

ghost commented 2 years ago

please upload images instead of linking them, for future reviewers. Also, which side should be the good one?

illwieckz commented 2 years ago

Those are the images in first post, just reuploaded with a slider.

illwieckz commented 2 years ago

/devmap station15 /setviewpos 349 -1031 -143 159 32

This part must not be pitch black, the fact it's renderer pitch black is because it's worked around with r_clear 1, otherwise nothing would be painted at all.

nolightmap bug

If you /set r_clear 0 and move a bit, you'll see the void.

illwieckz commented 2 years ago

This is probably related to the fact those two models are colliding.