Dafang-Hacks / Main

138 stars 63 forks source link

latest live555 #70

Closed claud9999 closed 3 years ago

claud9999 commented 3 years ago

Closes #68

So I have at least gotten the code to compile; I will test it tomorrow (consider this PR a "draft", it may be updated if I broke anything.) I am not 100% sure I understand the Live555 API changes and I'm really rusty on C++ so apologies if I've made a bone-headed mistake. I hope to test tomorrow on my cams.

Beyond updating the v4lrtspserver-master code, this adds the "current working version" of live555, which does not exist in an SCM so it's really wise that we maintain our own copy of what we understand so that the latest version doesn't change API's out from under us. This may also be true of other libraries that we rely on, particularly those that are not maintained in github or another public SCM repo.

claud9999 commented 3 years ago

of course you can mostly ignore everything under the Modules/live folder (although you'd be wise to doublecheck it against the official release of live555, not that I introduced any backdoors or anything, but good to make it a habit to validate it.)

It might be worthwhile to have the compile script download the current official release and warn if it's newer than what we have in our repo. But live555 seems to change weekly so that might be annoying.

nik0 commented 3 years ago

let's do like that ! Tell me when you tested ...

claud9999 commented 3 years ago

Ok my testing uncovered one bug in my code, but otherwise it's looking good! Please consider merging into master.

nik0 commented 3 years ago

Done Thanks Keep this project moving !! 👍🏻👍🏻