Icon does not update when using back button

[gboonie]

When going back to the last page using the back button, the icon does not update. When clicking the icon it does show the correct IP in the pop-up though.

[Dagger0]

Thanks for the report. I fixed this in 0.8(.1), which you can get from https://addons.mozilla.org/en-US/firefox/addon/ipvfox/versions/.

(It's not showing up on the main page because it's in the "full review" queue, which is over a month long at the moment.)

[gboonie]

Hi,

I updated and it is solved.

But there is still an issue. Now when you click a link, click back, click forward... You will see a questionmark.

Thanks for this plugin. I love it.

Dave

Op 4 okt. 2011 om 07:53 heeft Dagger0reply@reply.github.com het volgende geschreven:

Thanks for the report. I fixed this in 0.8(.1), which you can get from https://addons.mozilla.org/en-US/firefox/addon/ipvfox/versions/.

(It's not showing up on the main page because it's in the "full review" queue, which is over a month long at the moment.)

Reply to this email directly or view it on GitHub: https://github.com/Dagger0/IPvFox/issues/1#issuecomment-2282776

[Dagger0]

It depends where the page is loaded from... if it was stored in the bfcache (i.e. the page was just hibernated), the list will show the original hosts. If the page had to be reloaded, it'll show the hosts used for the new load -- which might indeed be an empty list, if the page came from the disk cache.

Try it on something like https://ftp.mozilla.org/ (or disable Javascript and test on GitHub).

(There is a "http-on-examine-cached-response" notification that's fired for loads from the disk cache, so I could perhaps add them to the list with an IP of "(cached)" or something similar, which would make the from-cache case a bit more obvious.)

I did notice while testing that there's a delay updating the icon on back/forward, which I've now fixed. It's easily noticeable if you load the Commits page, navigate somewhere else and then hit back; if the page comes completely from disk cache it keeps displaying the old status until it's finished loading.

[gboonie]

Clear explanation.

Showing the questionmark is just fine when loading from the cache. I like it better than a cached value which could show a different IP than after a reload. Now I understand, I'm happy as it is.

Thanks a lot

Dave

Op 4 okt. 2011 om 20:41 heeft Dagger0reply@reply.github.com het volgende geschreven:

It depends where the page is loaded from... if it was stored in the bfcache (i.e. the page was just hibernated), the list will show the original hosts. If the page had to be reloaded, it'll show the hosts used for the new load -- which might indeed be an empty list, if the page came from the disk cache.

Try it on something like https://ftp.mozilla.org/ (or disable Javascript and test on GitHub).

(There is a "http-on-examine-cached-response" notification that's fired for loads from the disk cache, so I could perhaps add them to the list with an IP of "(cached)" or something similar, which would make the from-cache case a bit more obvious.)

I did notice while testing that there's a delay updating the icon on back/forward, which I've now fixed. It's easily noticeable if you load the Commits page, navigate somewhere else and then hit back; if the page comes completely from disk cache it keeps displaying the old status until it's finished loading.

Reply to this email directly or view it on GitHub: https://github.com/Dagger0/IPvFox/issues/1#issuecomment-2289735