search

DagsHub / papers-with-everything

Machine Learning papers with code, data and models
28 stars 10 forks source link

Added Directory on Paper One_shot_Face_Reenactment #23

Closed Bharat-mtr closed 1 year ago

Bharat-mtr commented 1 year ago

This is regarding Issue #21 Added directory for Paper One_shot_Face_Reenactment.

Paper :- https://arxiv.org/pdf/1908.03251

Fixes #21

Repository:- https://dagshub.com/Bharat-mtr/One_Shot_Face_Reenactment

Bharat-mtr commented 1 year ago

@nirbarazida Please review and let me know if I need to add/edit anything.

Bharat-mtr commented 1 year ago

Overall this is another great contribution! Thanks for taking part!

I have one comment to fix – there are a lot of redundant mac related files and folders, mainly a _MACOSX folder here: https://dagshub.com/Bharat-mtr/One_Shot_Face_Reenactment/src/master/sample_images/LOFR%20synthetic%20images as well as .DS_Store files all over the project. Could you please remove them, as they aren't necessary, take up space, and make navigation more confusing.

After they are removed, we can merge this in.

Thanks again, Dean

I have removed the redundancy. Although the DagsHub repo is taking time to get in sync with Github repo changes.

deanp70 commented 1 year ago

Have you pushed the new git version? It shows me last update was a week ago.

Let me know once it's pushed and I'll re-check

Bharat-mtr commented 1 year ago

Have you pushed the new git version? It shows me last update was a week ago.

Let me know once it's pushed and I'll re-check

I have pushed changes to corresponding git repo of One_Shot DagsHub Repo Git repo :- https://github.com/Bharat-mtr/One_Shot_Face_Reenactment

Its taking time to show same changes in DagsHub Repo

https://dagshub.com/Bharat-mtr/One_Shot_Face_Reenactment

its showing sync in progress, although I have committed the changes in git repo.