search

DagsHub / papers-with-everything

Machine Learning papers with code, data and models
28 stars 10 forks source link

Added Directory for Neural Rays for Occlusion-aware Image-based Rendering #39

Closed Bharat-mtr closed 1 year ago

Bharat-mtr commented 1 year ago

This is regarding Issue #37 Added Directory on Neural Rays for Occlusion-aware Image-based Rendering

Paper :- https://arxiv.org/pdf/2107.13421.pdf Repository:- https://dagshub.com/Bharat-mtr/NeuRay

Fixes #37

Bharat-mtr commented 1 year ago

@nirbarazida Please review and let me know if I need to add/edit anything.

nirbarazida commented 1 year ago

Hey @Bharat-mtr,

Thanks for your contribution to our challenge!

I had only one small comment for this PR. please review it, make the changes and we'd love to merge it!

Bharat-mtr commented 1 year ago

Hey @Bharat-mtr,

Thanks for your contribution to our challenge!

I had only one small comment for this PR. please review it, make the changes and we'd love to merge it!

Hi @nirbarazida ,

Thanks for reviewing. Please let me know what i need to change/add to this PR. I can't see where you added the comment about this PR.

Thanks.

nirbarazida commented 1 year ago

Hey @Bharat-mtr ,

My comment is on lines 35-37 where you refer to a different platform to download the model and dataset, which is missing the point of the challenge. Please modify it and instruct how to use DagsHub & DVC to pull them.

Bharat-mtr commented 1 year ago

Hey @Bharat-mtr ,

My comment is on lines 35-37 where you refer to a different platform to download the model and dataset, which is missing the point of the challenge. Please modify it and instruct how to use DagsHub & DVC to pull them.

I have updated the README as you said. Please review it and let me know if I need to add/edit anything. Thanks!

Bharat-mtr commented 1 year ago

I have made the required changes, please review it @nirbarazida @deanp70 and merge it.

deanp70 commented 1 year ago

Thank you for your contribution! I've merged this in! Nice job